This repository has been archived by the owner on Sep 7, 2020. It is now read-only.
support customized attibutes and aria-* attributes #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A perfect PR, thanks a lot! I like the look of the changes and the tests, it makes sense to me. If React has this edge case supported then so should we. |
Olical
added a commit
that referenced
this pull request
Oct 31, 2015
support customized attibutes and aria-* attributes
| @@ -88,7 +88,13 @@ Element.prototype.attributeNameMappings = { | |||
| } | |||
|
|
|||
| Element.prototype.attributeToPropName = function (name) { | |||
| return this.attributeNameMappings[name] || camelCase(name) | |||
| if (name.match(/^data-/)) { | |||
There was a problem hiding this comment.
I forgot to mention before I merged it that these RegExps should probably be initialised in a closure (cached and reused).
There was a problem hiding this comment.
OK, I'll send another PR if I have time to fix it. Thanks 👍
|
I opened an issue as a reminder, I'll get around to it if not but feel free! :) thanks. |
|
Published in v2.1.0 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://facebook.github.io/react/docs/jsx-gotchas.html#custom-html-attributes
Customized attributes like
data-custom-attributesare converted into camel case, it should not be converted. So doesaria-*attributes.