Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci fix v2 #363

Merged
merged 59 commits into from
May 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
fc2b93b
LOD using neg ctrl or fixed LOD function
kathy-nevola May 20, 2024
00d54e8
Document
kathy-nevola May 20, 2024
60dab69
merge by DataRefID
kathy-nevola May 20, 2024
b4f6770
documentation update
kathy-nevola May 20, 2024
951ff7a
Merge branch 'fix_lod' of https://github.com/Olink-Proteomics/OlinkRP…
kathy-nevola May 20, 2024
adc374d
update documentation, example still needed
kathy-nevola May 20, 2024
a22aa3b
update snapshots
kathy-nevola May 20, 2024
6afc283
Structuring and cleanup of the code
klevdiamanti May 21, 2024
1385bed
Document olink_lod
klevdiamanti May 21, 2024
a3e332c
Install arrow for mac
kathy-nevola May 21, 2024
65b050d
remove fail fast
kathy-nevola May 21, 2024
bc02cc8
return to base state
kathy-nevola May 21, 2024
de2f99e
create new mac workflow
kathy-nevola May 21, 2024
34e560a
add mac back to json
kathy-nevola May 21, 2024
bf9946c
move matrix install for ubuntu?
kathy-nevola May 21, 2024
87e619e
define matrix config
kathy-nevola May 21, 2024
c9ddb7e
add version specific matrix for old R support
kathy-nevola May 22, 2024
e005349
remove 4.2 from previous checks
kathy-nevola May 22, 2024
cf02d88
rename to debug
kathy-nevola May 22, 2024
4c6860f
ignore matrix on older R versions
kathy-nevola May 22, 2024
6baf8f6
Install Matrix 1.6-2 from source
klevdiamanti May 23, 2024
18a8f89
Also install lattice
klevdiamanti May 23, 2024
386182a
Install Matrix 1.6-5 from source as a extra-package
klevdiamanti May 23, 2024
7accbee
also install ggtree from source
klevdiamanti May 23, 2024
4c8ca18
Also install ggplot2 3.3.6
klevdiamanti May 23, 2024
8bf9f1d
Bug fix install ggplot2 3.3.6
klevdiamanti May 23, 2024
4fe6919
Remove white space
klevdiamanti May 23, 2024
997b4a8
Move Mac to R-CMD-check
klevdiamanti May 23, 2024
04b4259
switch to matrix.config.os
klevdiamanti May 23, 2024
6625a8c
Add missing single quote
klevdiamanti May 23, 2024
530fbc6
Install arrow from r-universe after OA installation
klevdiamanti May 23, 2024
adaff8c
Remove R 4.2.0 from workflow matrix
klevdiamanti May 23, 2024
05f29ea
Go back to using matrix from workflow
klevdiamanti May 23, 2024
6094c08
Do not install Matrix from source in R-CMD-check matrix
klevdiamanti May 23, 2024
20960fa
Test docker bases R CMD check
AskPascal May 23, 2024
42d394c
Fix
AskPascal May 23, 2024
92b1c5a
Test full matrix
AskPascal May 23, 2024
c460fa1
Run tests on later minor releases
AskPascal May 23, 2024
6e6d6c1
test using {bspm}
AskPascal May 24, 2024
f594df2
Use devtools::install_dev_deps()
AskPascal May 24, 2024
b8434a9
Run checks without suggested packages
AskPascal May 24, 2024
9069448
Removing R 4.1.3 renv and R 4.2.0 checks because they're handled by d…
klevdiamanti May 24, 2024
e3c2467
Remove json file specific for mac
klevdiamanti May 24, 2024
189250a
Add Ubuntu 22.04 to workflows
klevdiamanti May 24, 2024
e55c2ac
Check R development version on Ubuntu 22.04
klevdiamanti May 24, 2024
ca1bde3
Check R latest Ubuntu 20.04 only on PR
klevdiamanti May 24, 2024
c7aa875
Remove empty lines
klevdiamanti May 24, 2024
87b55c9
Run docker on on PRs
klevdiamanti May 24, 2024
1d60b01
Remove renv as we moved to deckerized checks for earlier R versions
klevdiamanti May 24, 2024
3dcd103
olink_normalization do not use expect_no_warning in R <= 4.2.0
klevdiamanti May 24, 2024
f3171a8
Require testthat >= 3.2.0
klevdiamanti May 24, 2024
abb8689
Roll back to requiring testthta >= 3.0.0
klevdiamanti May 24, 2024
9e323ad
Skip tests with expect_no_error/expect_no_warning in R < 4.2.0
klevdiamanti May 24, 2024
9209409
Add case_match and pick from dplyr to NAMESPACE
klevdiamanti May 24, 2024
3e1c604
Add .env and .data to global variables
klevdiamanti May 24, 2024
f3436f7
bugfix typo
klevdiamanti May 24, 2024
ef2a8fb
Document
klevdiamanti May 24, 2024
3da7dcb
Switch from dplyr::case_match to nested dplyr::if_else to pass R 4.1.…
klevdiamanti May 24, 2024
1e63a5d
dropping dplyr::pick to get CI to work with R 4.1.3
klevdiamanti May 24, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
104 changes: 11 additions & 93 deletions .github/workflows/R-CMD-check.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,15 @@ jobs:
inputFile: '.github/workflows/matrix_config_check.json'
filter: '[?runOn==`${{ github.event_name }}` || runOn==`always`]'
# addInclude: true

R-CMD-check:
needs: matrix_prep
strategy:
fail-fast: false
matrix: ${{fromJson(needs.matrix_prep.outputs.matrix)}}
strategy:
fail-fast: false
matrix: ${{fromJson(needs.matrix_prep.outputs.matrix)}}

runs-on: ${{ matrix.os }}
timeout-minutes: 120
timeout-minutes: 120

name: ${{ matrix.os }} (${{ matrix.r }})

Expand All @@ -42,7 +42,7 @@ jobs:
- uses: r-lib/actions/setup-r@v2
with:
r-version: ${{ matrix.r }}
use-public-rspm: true
use-public-rspm: true

- uses: r-lib/actions/setup-pandoc@v2
with:
Expand All @@ -54,100 +54,18 @@ jobs:
forenv <- paste("R_BIOC_VERSION=", as.character(remotes::bioc_version()), sep = "")
write(forenv, file = Sys.getenv("GITHUB_ENV"), append = TRUE) # Store current value to ENV
shell: Rscript {0}



- uses: r-lib/actions/setup-r-dependencies@v2
with:
working-directory: OlinkAnalyze
extra-packages: any::rcmdcheck, pillar

- name: Install Matrix from source
- name: Install arrow from r-universe
if: matrix.os == 'macOS-latest'
run: |
install.packages("Matrix", type="source", repos='http://cran.us.r-project.org')
install.packages('arrow', repos = c('https://apache.r-universe.dev'))
shell: Rscript {0}

- uses: r-lib/actions/check-r-package@v2
with:
working-directory: OlinkAnalyze


R-CMD-check-renv:
needs: matrix_prep
strategy:
fail-fast: false
matrix:
config:
- {os: ubuntu-22.04, r: '4.1.3'}


runs-on: ${{ matrix.config.os }}
timeout-minutes: 120

name: ${{ matrix.config.os }} (${{ matrix.config.r }})

env:
R_REMOTES_NO_ERRORS_FROM_WARNINGS: true
_R_CHECK_FORCE_SUGGESTS_: false
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}

steps:
- uses: actions/checkout@v2

- name: Install package
run: |
sudo apt update
sudo apt-get -y install libglpk-dev texlive-latex-base \
texlive-fonts-recommended texlive-fonts-extra texlive-latex-extra

- uses: r-lib/actions/setup-r@v2
with:
r-version: ${{ matrix.config.r }}
use-public-rspm: true

- uses: r-lib/actions/setup-pandoc@v2
with:
pandoc-version: '2.18'

- name: Set RENV_PATHS_ROOT
shell: bash
run: |
echo "RENV_PATHS_ROOT=${{ runner.temp }}/renv" >> $GITHUB_ENV

- name: Install and activate renv
run: |
install.packages("remotes")
remotes::install_version("renv", "0.16.0")
renv::activate(profile = "r413")
shell: Rscript {0}

- name: Get R and OS version
id: get-version
run: |
cat("os-version=", sessionInfo()$running, "\n", file = Sys.getenv("GITHUB_OUTPUT"), sep = "", append = TRUE)
cat("r-version=", R.Version()$version.string, "\n", file = Sys.getenv("GITHUB_OUTPUT"), sep = "", append = TRUE)
shell: Rscript {0}

- name: Restore Renv package cache
uses: actions/cache@v3
with:
path: ${{ env.RENV_PATHS_ROOT }}
key: ${{ steps.get-version.outputs.os-version }}-${{ steps.get-version.outputs.r-version }}-${{inputs.cache-version }}-${{ hashFiles('renv.lock') }}
restore-keys: ${{ steps.get-version.outputs.os-version }}-${{ steps.get-version.outputs.r-version }}-${{inputs.cache-version }}-

- name: Install renv dependencies
run: renv::restore()
shell: Rscript {0}

- name: Check package
run: |
check_results <- rcmdcheck::rcmdcheck(error_on = "error",
path = "OlinkAnalyze",
check_dir = "check")
shell: Rscript {0}

- name: Upload check results
if: failure()
uses: actions/upload-artifact@v3
with:
name: ${{ runner.os }}-r${{ matrix.config.r }}-results
path: "check"
working-directory: OlinkAnalyze
12 changes: 6 additions & 6 deletions .github/workflows/matrix_config_check.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,16 @@
{
"os": "ubuntu-20.04",
"r": "release",
"runOn": "always"
"runOn": "pull_request"
},
{
"os": "ubuntu-20.04",
"r": "devel",
"runOn": "pull_request"
"os": "ubuntu-22.04",
"r": "release",
"runOn": "always"
},
{
"os": "ubuntu-20.04",
"r": "4.2.0",
"os": "ubuntu-22.04",
"r": "devel",
"runOn": "pull_request"
}
]
40 changes: 40 additions & 0 deletions .github/workflows/r-cmd-check-docker.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
on: [pull_request]

name: R-CMD-check-docker

jobs:
R-CMD-check-docker:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
r_version: ["4.1.3", "4.2.3", "4.3.3", "4.4.0"]
steps:
-
name: Checkout
uses: actions/checkout@v3
-
name: Set up Docker Buildx
uses: docker/setup-buildx-action@v2
-
name: Build docker image
uses: docker/build-push-action@v4
with:
push: false
tags: oa:latest
cache-from: type=gha
cache-to: type=gha,mode=max
file: docker/Dockerfile_for_tests
load: true
build-args: R_VERSION=${{matrix.r_version}}
-
name: Run rcmdcheck
run: |
echo "rcmdcheck::rcmdcheck(path = '/OA', check_dir = '/check', error_on = 'warning')" | docker run -i -v "$(pwd)/OlinkAnalyze":/OA -v "$(pwd)/check":/check oa:latest
-
name: Upload check results
if: failure()
uses: actions/upload-artifact@main
with:
name: docker-r${{ matrix.config.r }}-check-results
path: check
2 changes: 1 addition & 1 deletion OlinkAnalyze/DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -111,5 +111,5 @@ VignetteBuilder:
Config/testthat/edition: 3
Encoding: UTF-8
LazyData: true
RoxygenNote: 7.2.3
RoxygenNote: 7.3.1
URL: https://olink.com/ https://github.com/Olink-Proteomics/OlinkRPackage
1 change: 1 addition & 0 deletions OlinkAnalyze/NAMESPACE
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ export(olink_heatmap_plot)
export(olink_lmer)
export(olink_lmer_plot)
export(olink_lmer_posthoc)
export(olink_lod)
export(olink_normalization)
export(olink_normalization_bridge)
export(olink_normalization_n)
Expand Down
3 changes: 2 additions & 1 deletion OlinkAnalyze/R/globals.R
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,6 @@ utils::globalVariables(unique(c(
"umapX_low", "umapY_high", "umapY_low", "LX", "LY", "PCX", "PCY", "rowname", "Normalization", "Quantified_value", "v1",
"v2", "v", "v_name", "duplicateID", "SampleID_df1", "name", "data", "normalize_to", "PlateID1", "QC_Warning1", "V1", "V2",
"cols", "ID", "AssayQC", "AssayType", "Block", "DataAnalysisRefID", "ExploreVersion", "ExtNPX", "PCNormalizedNPX", "SampleQC", "SampleType", "WellID",
"Max LOD", "Plate LOD", "Plate_LOD", "Normalization_df1", "Normalization_df2", "Max_LOD", "maxLOD", "plateLOD"
"Max LOD", "Plate LOD", "Plate_LOD", "Normalization_df1", "Normalization_df2", "Max_LOD", "maxLOD", "plateLOD",
".env", ".data"
)))
Loading
Loading