Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all wiki links in ombi UI #32

Closed
Berserkir-Wolf opened this issue Jan 19, 2021 · 5 comments
Closed

Update all wiki links in ombi UI #32

Berserkir-Wolf opened this issue Jan 19, 2021 · 5 comments
Assignees

Comments

@Berserkir-Wolf
Copy link
Collaborator

Oh. Oh no. This part will suck.

@tidusjar
Copy link
Member

Nah, should be pretty simple, each settings page has a

<wiki [url]="'xyz'"></wiki>

We just need to update the URL as part of that directive. But I'll pick up this bit of work to go a step futher where we don't have to provide the base url, but just the path e.g.

<wiki [path]="'/common-errors/'"></wiki>

@tidusjar tidusjar self-assigned this Jan 19, 2021
@Berserkir-Wolf
Copy link
Collaborator Author

Good thinking.
I'm nearly done with the main pages, just making sure paths etc are all logical. All pages should be finished by this weekend, ready for the switch in the UI itself.

@tidusjar
Copy link
Member

Cool, will get on that tonight

@Berserkir-Wolf
Copy link
Collaborator Author

All initial pages have been migrated/merged as needed. Only outstanding one is the migration page, because it's ugly.

Moving on to creating missing pages (several notification types etc only had blank pages).

@Berserkir-Wolf
Copy link
Collaborator Author

Every URL in settings is live either with a URL redirect (in the case of sonarr etc) or a placeholder page ready to have content added.
All links to the wiki in the web UI appear to just link to docs.ombi.app, not to docs.ombi.app/settings/item - given that redirects are live, is the plan to have Ombi use everything following the baseurl as the last part of the link target?
So if I'm on settings/email, the wiki button should point to docs.ombi.app/settings/email, even if I have ombi behind a baseurl.
Maybe wikilink = docsurl+currenturl.trimstart(applicationurl)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants