Localization - step 2 #4366
Merged
Localization - step 2 #4366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses TMDB instead of TVMaze for title, genres and synopsis
|
Thanks! I’ll take a look soon! |
tidusjar
reviewed
Nov 2, 2021
tidusjar
requested changes
Nov 2, 2021
src/Ombi/ClientApp/src/app/discover/components/card/discover-card.component.ts
Outdated
Show resolved
Hide resolved
src/Ombi/ClientApp/src/app/media-details/components/movie/movie-details.component.ts
Outdated
Show resolved
Hide resolved
...tApp/src/app/media-details/components/tv/panels/tv-request-grid/tv-request-grid.component.ts
Outdated
Show resolved
Hide resolved
src/Ombi/ClientApp/src/app/shared/episode-request/episode-request.component.ts
Outdated
Show resolved
Hide resolved
|
Thank you for your code review. All should be fixed, except the enum values: see my reply on the thread. |
|
Nice work! looks good! |
tidusjar
approved these changes
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Localize hard-coded texts in HTML ("New movies", etc. ) 🆘 help needed - is there any existing tool on the backend I can reuse to handle translations? If it's not the case, I'm considering the use of settings for such texts, like it was done for the subject and the leading textPostponed to a later PR until I find a clean way to do it.