Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor RegTest tests into package groups #13

Closed
msgilligan opened this issue Jan 20, 2015 · 4 comments
Closed

Refactor RegTest tests into package groups #13

msgilligan opened this issue Jan 20, 2015 · 4 comments

Comments

@msgilligan
Copy link
Member

This Issue assumes that Issue #12 will be completed first, although the same basic reorganization could be done in sub packages of org.mastercoin.

Currently all the useful Omni Protocol RegTest tests are in the org.mastercoin.test.rpc package. I propose a new package hierarchy to improve reporting. Something like:

  • foundation.omni.test.rpc.sto - Send To Owners tests
  • foundation.omni.test.rpc.dex - Distributed Exchange tests
  • foundation.omni.test.rpc.basic - basic tests of RPC functions
  • foundation.omni.test.rpc.misc - miscellaneous tests using RPC

This will allow us to view Jenkins reports at the package level and focus on a particular category of tests like "STO".

Currently the test Specs are all lumped together in a single package, generating this report. Adding an extra level of hierarchy here should make things more logical and allow us to write documentation with links to the reports for just one package, such as "STO".

@msgilligan
Copy link
Member Author

With STO, I'm imagining we could have something like:

  • STOBasicSuccessCasesSpec
  • STOExpectedErrorCasesSpec
  • STODataDrivenTestSpec
  • STOReservedBalancesSpec
  • STOTransactionOrderingSpec
  • STOBlockchainReorgTestSpec (maybe this would be in a different package of re-org tests)

As we drill down in to each Spec, we should see reports for each "feature" test and the feature descriptions (Groovy method names with spaces) should be human readable.

(We may also want to consider publishing the default Spock test report output if we feel it is more readable or navigable than the standard Jenkins reports. We may also want to look at Jenkins plugins.)

@dexX7
Copy link
Member

dexX7 commented Jan 20, 2015

I really like the report Groovy/Spock creates, and it would be great, if it were exported by default.

Even though the STO test plan can be splitted into groups such as "reserved balances" and "transaction ordering", in the end the actual tests are likely the same, but executed on another set of input data. At least that's my impression at the very moment. If we can group it into logical groups, I would really like it though.

msgilligan added a commit that referenced this issue Jan 20, 2015
@msgilligan
Copy link
Member Author

@dexX7 I created Issue #15 for exporting/publishing the Spock test report. The latest report for each job is available in the "workspace" of each job for users with accounts on the CI server.

@msgilligan
Copy link
Member Author

Implemented in commit e2d55a4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants