Refine waitForServer() logging #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- status messages are logged only once, if new or updated - status messages are logged as `INFO` - begin and end of waiting is logged as `DEBUG`
msgilligan
added a commit
that referenced
this pull request
Jul 3, 2015
Refine waitForServer() logging
| @@ -83,7 +84,7 @@ public Boolean waitForServer(int timeout) throws JsonRPCException { | |||
| status = e.getMessage(); | |||
| } catch (JsonRPCStatusException e) { | |||
| // If server is in "warmup" mode, e.g. validating/parsing the blockchain... | |||
| if ( e.jsonRPCCode == -28) { | |||
| if (e.jsonRPCCode == -28) { | |||
There was a problem hiding this comment.
We should probably start defining error codes symbolically, but this is fine for now.
(I realize that I put in the -28 and you just removed a space)
|
Thanks for the merge! Now the output looks like this: https://ci.omni.foundation/job/omni-mainnet-consensus/44/console Even though there are quite a few messages (it's printed every 30 seconds), it's very convenient to watch the progress, or spot, whether the parsing stalled. |
|
I'm going to move that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #74 (comment):
INFODEBUG