Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match specw/code append/replace not yet supported #221

Merged
merged 1 commit into from
Nov 4, 2014
Merged

Match specw/code append/replace not yet supported #221

merged 1 commit into from
Nov 4, 2014

Conversation

zathras-crypto
Copy link
Contributor

No description provided.

@ghost
Copy link

ghost commented Jul 4, 2014

+1 this adds more specificity for implementors

@dexX7
Copy link
Member

dexX7 commented Jul 6, 2014

What happens in such a case? Are those transactions currently invalidated?

@marv-engine
Copy link

@zathras-crypto how is append/replace not supported by the code? Other than validity checking, it's an example of what I have referred to as an application-advisory attribute.

@zathras-crypto
Copy link
Contributor Author

Property Type >2 currently invalidated yes.

@marv, not yet implemented is the same as unsupported. Masterchest for
example invalidates property types >2. There is no current code for
notifying the user at the UI layer of a replace or append. Masterchest is
end of life so won't be updated to support this.

If I recall correctly SP was built on multiple codebases and dragged to
consensus in about 3 and a half weeks, those types of timeframes dictate
prioritization, and if memory serves replace/append was put on the "not
important can wait until a later time" list.

Fairly low hanging fruit to do replace/append in Core (when it is the sole
implementation, not until).

Thanks
Z

On Tue, Jul 8, 2014 at 6:56 AM, Marv Schneider notifications@github.com
wrote:

@zathras-crypto https://github.com/zathras-crypto how is append/replace
not supported by the code? Other than validity checking, it's an example of
what I have referred to as an application-advisory attribute.


Reply to this email directly or view it on GitHub
#221 (comment).

dacoinminster pushed a commit that referenced this pull request Nov 4, 2014
Match specw/code append/replace not yet supported.

Appears uncontroversial. Merging.
@dacoinminster dacoinminster merged commit a5f7d96 into OmniLayer:master Nov 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants