Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

high-level terms in paper #2

Closed
alanruttenberg opened this issue Nov 19, 2015 · 11 comments
Closed

high-level terms in paper #2

alanruttenberg opened this issue Nov 19, 2015 · 11 comments
Assignees

Comments

@alanruttenberg
Copy link
Contributor

Guy: There are a total of five placeholders (high-level terms) described in our paper: ribosomal RNA (rRNA), transfer RNA (tRNA), long non-coding RNA (lncRNA), small nuclear RNA (snRNA), and small interfering RNA (siRNA). When you edit NCRO, please add them as direct children of the term “ncRNA.” Thanks!

Jingshan

@alanruttenberg
Copy link
Contributor Author

Done. Waiting for review from Jingshan.

@Huang-OMIT
Copy link
Contributor

  1. How do we handle the “small_regulatory_ncRNA” tree and other child terms defined underneath "ncRNA" in SO, including lncRNA, rRNA, siRNA, snRNA, and tRNA?
  2. Can we go back to original imports for "organism," "cell," and "cell line?" - from OBI (0100026), CL (0000000), and CLO (000031), respectively.
  3. ontology-metadata.owl appears in both Direct and Indirect Imports in Protege.
  4. Do we wanna add "id" annotation for NCRO terms? Especially, those terms in higher levels.

@harrisonstrachan
Copy link
Collaborator

The following ObjectProperties are still using the old prefix ncro-obo-WorkingVersion-######:
IAO_0000117
has_integral_part
homologous_to
integral_part_of
member_of
non_functional_homolog_of
part_of
similar_to

@Huang-OMIT
Copy link
Contributor

Alan: Can u take care of bullets 2, 3, and 4 in my comment, and Harrison's comment as well?

@Huang-OMIT
Copy link
Contributor

Alan: Some more issues identified.
Redundant relations: three "part_of" and two "has_part" - Need to remove redundant ones.
Relation imported from BFO 1.1: "occurs in" - Can it be replaced with some OBO_REL relation?
Relations "has output," "regulates," "negatively regulates," and "positively regulates" are imported from RO - Do they need to be replaced with some OBO_REL relation?

@alanruttenberg
Copy link
Contributor Author

I will look at these. I noticed them as well an was planning to clean them
up. Happy to hear that you are too and seeing the same issues I do :)

On Tue, Dec 1, 2015 at 3:50 PM Jingshan Huang notifications@github.com
wrote:

Alan: Some more issues identified.
Redundant relations: three "part_of" and two "has_part" - Need to remove
redundant ones.
Relation imported from BFO 1.1: "occurs in" - Can it be replaced with some
OBO_REL relation?
Relations "has output," "regulates," "negatively regulates," and
"positively regulates" are imported from RO - Do they need to be replaced
with some OBO_REL relation?


Reply to this email directly or view it on GitHub
#2 (comment).

@Huang-OMIT
Copy link
Contributor

Another issue identified: there are some relations with ID like "OBO_REL#_adjacent_to" - do we wanna change to some equivalent relation ID without "#" OR leave as is?

@alanruttenberg
Copy link
Contributor Author

We want to fix them

@Huang-OMIT
Copy link
Contributor

Ok.

@Huang-OMIT
Copy link
Contributor

(1) If a similar/equivalent relation is found that does not have "#", we simply import that relation.
(2) Otherwise, are we able to change the ID of an imported relation?

@alanruttenberg
Copy link
Contributor Author

Resolved in dea10b2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants