Support for partitionless panels e.g. iConnect2. #2

SimonThoustrup · 2021-02-02T11:35:36Z

Hey there.
I've added support for partitionless control panels such as the iConnect2 ref. home-assistant/core#40290. I've tested the changes in my Home Assistant and I have no errors in the log from the Risco integration. I hope I haven't broken anything for the panels that support partitions.
Please let me know if you think anything should be done differently.
Thanks.

OnFreund

Thanks @SimonThoustrup. Let's figure out a more object oriented approach. This will also ensure less risk of changes to one systems breaking the other.
Ideally, I would like the decision point to be as early as possible, say another RiscoAPI implementation, and a single method that return either implementation depending on what type of system you have. From then on, the implementation should be separate with common base classes.

Thanks again!

OnFreund · 2021-02-09T08:05:44Z

pyrisco/risco.py

@@ -36,41 +44,60 @@


 class Partition:
-    """A representation of a Risco partition."""
+    """A representation of a Risco partition (or panel in case of no partitions)."""


I think this should be a different class in the no partition case, since basically all properties now have the same if self._partitions_available: pattern. They can have a common base.

OnFreund · 2021-02-09T08:07:25Z

pyrisco/risco.py

@@ -131,7 +161,10 @@ def __init__(self, raw):
    def partitions(self):
        """Alarm partitions."""
        if self._partitions is None:
-            self._partitions = {p["id"]: Partition(p) for p in self._raw["partitions"]}
+            if self._raw["partitions"] is not None:


Not sure about this, but maybe better to return an empty collection and have a different property to return the partition-like object for non partition systems? Or maybe rename this property to panels?

OnFreund · 2021-02-09T08:08:49Z

pyrisco/risco.py

@@ -329,28 +363,50 @@ async def login(self, session=None):
    async def get_state(self):
        """Get partitions and zones."""
        resp = await self._site_post(STATE_URL, {})
+        if resp["state"]["status"]["partitions"] is None:
+            self._partition_panel = False


Once again, we're repeating the same if self._partition_panel: in multiple locations. Let's find an OO way to represent this better.

SimonThoustrup · 2021-02-10T07:48:16Z

Thanks @OnFreund. I won’t have time to work on this for the next few weeks so if somebody else want’s to pick it up please feel free to do so. If not I’ll have a go when time permits. :-)

Rookie-Ron · 2021-12-30T13:27:20Z

@SimonThoustrup Hi Simon, are there any developments in this area since February? I am still struggling with my 'Partitionless' Risco (MyElas) iConnect2 alarmsystem.
Any workarounds that you are aware of?

SimonThoustrup · 2021-12-30T13:52:48Z

Hi. Sorry but I haven’t had time to do the refactoring. The patch I made still works though so you might get away with placing the patched risco.py in site-packages/pyrisco/ in your HA install. I hope I will have some time to fix this properly sometime next year. Sent from my phone - likely short Fra: Rookie-Ron ***@***.***>Sendt: torsdag, december 30, 2021 2:28 PMTil: OnFreund/pyriscoCc: SimonThoustrup; MentionEmne: Re: [OnFreund/pyrisco] Support for partitionless panels e.g. iConnect2. (#2) @SimonThoustrup Hi Simon, are there any developments in this area since February? I am still struggling with my 'Partitionless' Risco (MyElas) iConnect2 alarmsystem. Any workarounds that you are aware of? —Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you were mentioned.Message ID: ***@***.***>

Rookie-Ron · 2021-12-30T22:17:45Z

@SimonThoustrup Thanks for the hint, no luck however. Maybe I do not have the process clear?
First I installed pyrisco in my Python3.9 /site-packages subfolder. Thereafter I overwrote 'risco.py' by your patched file (dated February 2, 2021). After restarting Home Assistant the old error message remains: "File "/usr/local/lib/python3.9/site-packages/pyrisco/risco.py", line 134, in partitions self._partitions = {p["id"]: Partition(p) for p in self._raw["partitions"]}".

This seems strange, as the file the error points to is your patched one, in which line 134 has your updated content.
Probable I need to a different installation process? Can you help me?

Rookie-Ron · 2022-01-02T21:59:38Z

@SimonThoustrup @OnFreund
Being a 'rookie' in Docker indeed (running Home Assistant core-2021.12.7 in Docker), I discovered I needed to replace the 'risco.py' within the Home Assistant container, rather than in the host OS directory... After a restart of HAss the patched 'risco.py' resulted in the proper 'alarm_control_panel' domain and panel status indication, also in Lovelace:

Some issues remain for this moment:

"inschakelen voor thuis" (= arm_home) does not function (Risco 'partial_arm'?), and results in the log:

Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/components/websocket_api/commands.py", line 185, in handle_call_service
await hass.services.async_call(
File "/usr/src/homeassistant/homeassistant/core.py", line 1495, in async_call
task.result()
File "/usr/src/homeassistant/homeassistant/core.py", line 1530, in _execute_service
await handler.job.target(service_call)
File "/usr/src/homeassistant/homeassistant/helpers/entity_component.py", line 209, in handle_service
await self.hass.helpers.service.entity_service_call(
File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 663, in entity_service_call
future.result() # pop exception if have
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 896, in async_request_call
await coro
File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 700, in _handle_entity_call
await result
File "/usr/src/homeassistant/homeassistant/components/risco/alarm_control_panel.py", line 148, in async_alarm_arm_home
await self._arm(STATE_ALARM_ARMED_HOME, code)
File "/usr/src/homeassistant/homeassistant/components/risco/alarm_control_panel.py", line 174, in _arm
await self._call_alarm_method(risco_state)
File "/usr/src/homeassistant/homeassistant/components/risco/alarm_control_panel.py", line 177, in _call_alarm_method
alarm = await getattr(self._risco, method)(self._partition_id, *args)
File "/usr/local/lib/python3.9/site-packages/pyrisco/risco.py", line 409, in partial_arm
return Alarm(await self._site_post(CONTROL_URL_NO_PARTITIONS, body))
File "/usr/local/lib/python3.9/site-packages/pyrisco/risco.py", line 300, in _site_post
return await self._authenticated_post(site_url, site_body)
File "/usr/local/lib/python3.9/site-packages/pyrisco/risco.py", line 287, in _authenticated_post
raise OperationError(str(json))
pyrisco.risco.OperationError: {'result': 52, 'validationErrors': None, 'errorText': None, 'errorTextCodeID': '0', 'status': 200, 'response': {'classVersion': 0, 'partitions': None, 'systemStatus': 0, 'systemReady': True, 'trouble': False, 'bellStatus': 0, 'alarmPending': False, 'batteryLow': False, 'acLost': False, 'haEnabled': False, 'bellOn': False, 'zones': None, 'haDevices': None, 'users': None, 'devCollection': None, 'exitDelayTimeout': 0, 'armNotAllowed': False, 'disarmNotAllowed': False, 'cpTime': '2022-01-02T21:05:01.9332344+00:00', 'partReadySupported': False, 'partFullReady': False, 'part1Ready': False, 'part2Ready': False, 'type': 2}}

Function "inschakelen voor vertrek" (=arm_away) does work as expected.

If I activate "inschakelen voor thuis" (= arm_home) through the alarm panel itself (and my mobile phone) it results in status 'unknown' when the alarm is (partially)armed:

For this: Comments on the Log? Is there something I should do in the mapping of 'arm_home' versus 'partial_arm'? Is 'arm_home' supported anyway?

ASOUAMES · 2022-05-10T13:09:52Z

Hi @Rookie-Ron

How did you replace the 'risco.py' within the Home Assistant container? I cant find the path. I am running HA OS on oracle virtualbox.

Can you please post a guide on how you did it?

Thank you.

Rookie-Ron · 2022-05-10T20:22:21Z

Hi @Rookie-Ron

How did you replace the 'risco.py' within the Home Assistant container? I cant find the path. I am running HA OS on oracle virtualbox.

Can you please post a guide on how you did it?

Thank you.

I am running Home Assistant (core) in a Docker Container. The container has his own file structure, which you can access with command:

sudo docker exec -it homeassistant sh

When you change to the main directory with cd /, the ls command will show you the file structure.

'risco.py' is under /usr/local/lib/python3.9/site-packages/pyrisco

To replace the default file with the patched one, from the directory where you saved the patch, use:

sudo docker cp risco.py homeassistent:/usr/local/lib/python3.9/site-packages/pyrisco/risco.py

One downside: after each update of Home Assistant you need to copy the patch to replace the original file.

Good luck!

ASOUAMES · 2022-08-04T07:04:16Z

Hey there,

Are you having issues after update Homeassistant 2022.8.0?

I replaced the default file with the patched one:
sudo docker cp risco.py homeassistant:/usr/local/lib/python3.10/site-packages/pyrisco/risco.py

and I get an error: Error while setting up risco platform for alarm_control_panel

It worked flawlessly before the update.

Any ideas?

Thank you!

OnFreund · 2022-08-04T08:14:05Z

The API has changed with the latest version, so whatever patch you're using will have to change accordingly.

ASOUAMES · 2022-08-04T09:59:44Z

Thank you @OnFreund for the explanation.

I am using @SimonThoustrup 's patch. Is this something that can be done easily?

OnFreund · 2022-08-04T10:52:59Z

Don't know - you'll have to ask Simon...

OnFreund · 2022-08-25T16:11:49Z

There hasn't been any real activity here for over 18 months, and the library has changed quite significantly in the mean time, so I'm closing this.

ASOUAMES · 2022-08-31T14:58:11Z

Hi @SimonThoustrup are you planning to make changes to your patch?

Rookie-Ron · 2022-09-13T08:02:51Z

Hi @SimonThoustrup, same issue and question from my side as @ASOUAMES. Are you planning an update to your patch to match the new API? Any hints how to do it myself?

ASOUAMES · 2022-09-20T07:43:29Z

Perhaps @SimonThoustrup is busy and cannot deal with this at the moment. Our only solution is for partitionless panels to be supported by @OnFreund. Hopefully one day.

OnFreund · 2022-09-20T07:54:45Z

@ASOUAMES as I mentioned multiple times - I don't have a partition-less panel and I don't have a way to develop and test for it.
I'm happy to provide assistance, but someone else will have to make it happen.

ASOUAMES · 2022-09-20T08:26:58Z

Understood, what if I gave you access to my panel? My knowledge of python is s..t.

OnFreund · 2022-09-20T08:29:31Z

That's not something I can develop remotely. It requires quick iterations
I don't have the API for local communication

ASOUAMES · 2023-03-16T08:04:39Z

lucacalcaterra/risco-mqtt-bridge#52

Found a work around. Perhaps it will help.

Added support for partitionless panels e.g. iConnect2.

fd47dff

SimonThoustrup changed the title ~~Added support for partitionless panels e.g. iConnect2.~~ Support for partitionless panels e.g. iConnect2. Feb 2, 2021

OnFreund requested changes Feb 9, 2021

View reviewed changes

Rookie-Ron mentioned this pull request Dec 30, 2021

Risco problem home-assistant/core#62927

Closed

Rookie-Ron mentioned this pull request Dec 31, 2021

integration pyrisco with Home assistant #4

Closed

OnFreund closed this Aug 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support for partitionless panels e.g. iConnect2. #2

Support for partitionless panels e.g. iConnect2. #2

SimonThoustrup commented Feb 2, 2021

OnFreund left a comment •

edited

Loading

OnFreund Feb 9, 2021

OnFreund Feb 9, 2021

OnFreund Feb 9, 2021

SimonThoustrup commented Feb 10, 2021

Rookie-Ron commented Dec 30, 2021

SimonThoustrup commented Dec 30, 2021 via email

Rookie-Ron commented Dec 30, 2021

Rookie-Ron commented Jan 2, 2022

ASOUAMES commented May 10, 2022

Rookie-Ron commented May 10, 2022

ASOUAMES commented Aug 4, 2022

OnFreund commented Aug 4, 2022

ASOUAMES commented Aug 4, 2022

OnFreund commented Aug 4, 2022

OnFreund commented Aug 25, 2022

ASOUAMES commented Aug 31, 2022

Rookie-Ron commented Sep 13, 2022

ASOUAMES commented Sep 20, 2022

OnFreund commented Sep 20, 2022 •

edited

Loading

ASOUAMES commented Sep 20, 2022

OnFreund commented Sep 20, 2022

ASOUAMES commented Mar 16, 2023

Support for partitionless panels e.g. iConnect2. #2

Support for partitionless panels e.g. iConnect2. #2

Conversation

SimonThoustrup commented Feb 2, 2021

OnFreund left a comment • edited Loading

Choose a reason for hiding this comment

OnFreund Feb 9, 2021

Choose a reason for hiding this comment

OnFreund Feb 9, 2021

Choose a reason for hiding this comment

OnFreund Feb 9, 2021

Choose a reason for hiding this comment

SimonThoustrup commented Feb 10, 2021

Rookie-Ron commented Dec 30, 2021

SimonThoustrup commented Dec 30, 2021 via email

Rookie-Ron commented Dec 30, 2021

Rookie-Ron commented Jan 2, 2022

ASOUAMES commented May 10, 2022

Rookie-Ron commented May 10, 2022

ASOUAMES commented Aug 4, 2022

OnFreund commented Aug 4, 2022

ASOUAMES commented Aug 4, 2022

OnFreund commented Aug 4, 2022

OnFreund commented Aug 25, 2022

ASOUAMES commented Aug 31, 2022

Rookie-Ron commented Sep 13, 2022

ASOUAMES commented Sep 20, 2022

OnFreund commented Sep 20, 2022 • edited Loading

ASOUAMES commented Sep 20, 2022

OnFreund commented Sep 20, 2022

ASOUAMES commented Mar 16, 2023

OnFreund left a comment •

edited

Loading

OnFreund commented Sep 20, 2022 •

edited

Loading