Example of how to write a test and refactor a class method #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds a detailed test for diesel_cost_columns - passes in an artificial DataFrame - checks output against hand-computed values - Removes lambda functions and apply method against whole DataFrame - Current implementation copies only parts of dataframe required, and returns small dataframe with the two new columns - Adds extra lines in runner in which new data is merged into main dataframe - Starts using `DataFrame.set_index()` method to index dataframe on lat/lon coordinates
AndreasSahlberg
approved these changes
Mar 5, 2020
|
@AndreasSahlberg - please do merge this if you are happy with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
returns small dataframe with the two new columns
DataFrame.set_index()method to index dataframe onlat/lon coordinates