Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invariance to scaling #22

Closed
OndrejNepozitek opened this issue Feb 9, 2018 · 0 comments
Closed

Invariance to scaling #22

OndrejNepozitek opened this issue Feb 9, 2018 · 0 comments

Comments

@OndrejNepozitek
Copy link
Owner

OndrejNepozitek commented Feb 9, 2018

Description

The algorithm should not depend on the scale of the rooms. If both polygons and respective doors are equally scaled, the algorithm should produce similar results with similar speed.

Steps to reproduce

None.

Actual results

The algorithm converges in a similar way with regard to the number of iterations. However, the number of iterations per second decreases as rooms are scaled up. It should be further investigated what part of the algorithms slows it down.

Expected results

Number of iterations and iterations per seconds should not be worse when scaling rooms up.

Notes for the thesis

The reason why scaling up the rooms yields worse results is still unknown.

Update 1

Picking a random intersection now operates in O(1) rather than in O(n) with "n" being the length of a chosen line.

Update 2

Method AddNodeGreedily was changed in a way that it does not search the whole space but rather it tries every i-th point. Where i is chosen in a way that the number of points is left the same. It increases the speed of iterations and has little effect on convergence rate.

ConfigurationSpacesGenerator is currently very slow when scaling up the rooms and must be reworked.

Benchmark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant