This repository has been archived by the owner on Aug 7, 2021. It is now read-only.
'Follow My Trip' Feature #833
Comments
Closed
aaronbrethorst
added a commit
that referenced
this issue
Nov 4, 2016
This feature wasn't so much driven by specific user request as it is driven to replace the hacky workarounds I've seen users use to accomplish the same thing. Here are the key points of this commit: 1. Allows users to share the trip they are taking with another person via text message or any other form of communication vended through UIActivityViewController. 2. Trips are shared via URL. These URLs encode the ID of the region that their trips belong to, which means that they are globally unique. They also do not depend on individual OBA region servers, which means that the iOS app doesn't need region server information hardcoded into it. 3. People with OneBusAway for iOS are taken to the trip itself when they tap on one of these links. 4. People without OBA for iOS are taken first to http://onebusaway.co, and then redirected to the appropriate region server's web page for that trip. ------- Fixes: * Fixes #833 - 'Follow My Trip' Feature * Fixes #840 - Implement Deep Linking * Fixes #847 - Add option to delete individual recent stops ------- Deep Links/Shared Trips: * Deep link router class * Create OBATripDeepLink model object * Shared Trip infrastructure for model DAO and the user defaults-based persistence layer * Display shared trips on the Recent tab * Delete shared trips older than 24 hours * Make it possible to render the ArrivalAndDeparture controller from a Trip Deep Link object * Start overhauling OBANavigationTarget * Wire up navigation target stuff for OBARecentStopsViewController * Shoehorn in a way to launch differently in response to deep links. * Unify navigation target, deep link, and 3D Touch quick action navigation systems Miscellaneous: * Move -escapePathVariable into OBAURLHelpers * Fix credits - turns out that I didn't end up adding the credits.html file back to the project when I did the big project reorg last month. Oops. Cell Swiping: * Add third party library YMSwipeTableViewCell to allow us to display icons on swiped cells (only on the stop view controller for now!) * Improved swipe menu for departure rows on the stops controller Icons: * New bookmark icons * Massively improve tab bar icons * Update launch storyboard - remove text and ensure that the icons are the correct, new ones * Add full sized icons from Noun Project to the Resources folder
aaronbrethorst
added a commit
that referenced
this issue
Nov 4, 2016
This feature wasn't so much driven by specific user request as it is driven to replace the hacky workarounds I've seen users use to accomplish the same thing. Here are the key points of this commit: 1. Allows users to share the trip they are taking with another person via text message or any other form of communication vended through UIActivityViewController. 2. Trips are shared via URL. These URLs encode the ID of the region that their trips belong to, which means that they are globally unique. They also do not depend on individual OBA region servers, which means that the iOS app doesn't need region server information hardcoded into it. 3. People with OneBusAway for iOS are taken to the trip itself when they tap on one of these links. 4. People without OBA for iOS are taken first to http://onebusaway.co, and then redirected to the appropriate region server's web page for that trip. ------- Fixes: * Fixes #833 - 'Follow My Trip' Feature * Fixes #840 - Implement Deep Linking * Fixes #847 - Add option to delete individual recent stops ------- Deep Links/Shared Trips: * Deep link router class * Create OBATripDeepLink model object * Shared Trip infrastructure for model DAO and the user defaults-based persistence layer * Display shared trips on the Recent tab * Delete shared trips older than 24 hours * Make it possible to render the ArrivalAndDeparture controller from a Trip Deep Link object * Start overhauling OBANavigationTarget * Wire up navigation target stuff for OBARecentStopsViewController * Shoehorn in a way to launch differently in response to deep links. * Unify navigation target, deep link, and 3D Touch quick action navigation systems Miscellaneous: * Move -escapePathVariable into OBAURLHelpers * Fix credits - turns out that I didn't end up adding the credits.html file back to the project when I did the big project reorg last month. Oops. Cell Swiping: * Add third party library YMSwipeTableViewCell to allow us to display icons on swiped cells (only on the stop view controller for now!) * Improved swipe menu for departure rows on the stops controller Icons: * New bookmark icons * Massively improve tab bar icons * Update launch storyboard - remove text and ensure that the icons are the correct, new ones * Add full sized icons from Noun Project to the Resources folder
aaronbrethorst
added a commit
that referenced
this issue
Nov 4, 2016
This feature wasn't so much driven by specific user request as it is driven to replace the hacky workarounds I've seen users use to accomplish the same thing. Here are the key points of this commit: 1. Allows users to share the trip they are taking with another person via text message or any other form of communication vended through UIActivityViewController. 2. Trips are shared via URL. These URLs encode the ID of the region that their trips belong to, which means that they are globally unique. They also do not depend on individual OBA region servers, which means that the iOS app doesn't need region server information hardcoded into it. 3. People with OneBusAway for iOS are taken to the trip itself when they tap on one of these links. 4. People without OBA for iOS are taken first to http://onebusaway.co, and then redirected to the appropriate region server's web page for that trip. ------- Fixes: * Fixes #833 - 'Follow My Trip' Feature * Fixes #840 - Implement Deep Linking * Fixes #847 - Add option to delete individual recent stops ------- Deep Links/Shared Trips: * Deep link router class * Create OBATripDeepLink model object * Shared Trip infrastructure for model DAO and the user defaults-based persistence layer * Display shared trips on the Recent tab * Delete shared trips older than 24 hours * Make it possible to render the ArrivalAndDeparture controller from a Trip Deep Link object * Start overhauling OBANavigationTarget * Wire up navigation target stuff for OBARecentStopsViewController * Shoehorn in a way to launch differently in response to deep links. * Unify navigation target, deep link, and 3D Touch quick action navigation systems Miscellaneous: * Move -escapePathVariable into OBAURLHelpers * Fix credits - turns out that I didn't end up adding the credits.html file back to the project when I did the big project reorg last month. Oops. Cell Swiping: * Add third party library YMSwipeTableViewCell to allow us to display icons on swiped cells (only on the stop view controller for now!) * Improved swipe menu for departure rows on the stops controller Icons: * New bookmark icons * Massively improve tab bar icons * Update launch storyboard - remove text and ensure that the icons are the correct, new ones * Add full sized icons from Noun Project to the Resources folder
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Blocked on #840
I imagine that this would look similar to Uber's "Follow My Trip" feature, except that it would all happen in-app (or in an iMessage extension?), and be predicated on tracking via the sharing of a particular vehicle ID.
This needs a lot more thinking-through to be ready for development, but here's more or less what I had in mind:
The text was updated successfully, but these errors were encountered: