Fix authentication issue for most users using javascript basic consumer implementation #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure what that snippet of code expects in terms of how the app was registered but it's not necessary for an out of the box implementation. Most users are having issues with this code because of that extra param. Removing it resolves the issue.
alvinalaphat
changed the title
alvinalaphat
changed the title
|
Which issue is this commit resolved? I still hit the issue when I close the picker window and launch it again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure what that snippet of code expects in terms of how the app was registered but it's not necessary for an out of the box implementation. Most users are having issues with this code because of that extra param. Removing it resolves the issue.