forked from Minestom/MinestomDataGenerator
-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to 1.21 #12
Merged
Merged
Update to 1.21 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: 1.21 new dynamic registries, new tag paths, generate game constants * chore: 1.21-pre2 * feat: generate all tags from client, 1.21-rc1, support generating snbt
…stom#28) * Add generation of feature flag namespaces. * Rewrite FeatureFlagGenerator.java to use a JsonObject instead of a JsonArray. --------- Co-authored-by: iam <iam4722202468@users.noreply.github.com>
… of our data artifact.
* feat: 24w14a, draft of component generator * feat: 1.20.5-pre4, entity dimension generator, cleanup material generator * chore: remove dimensions subobject on entities * feat: generate instruments, wolf variants, banner patterns * feat: generate recipe type ids * fix: recipe_type(s) * chore: update to release version * fix for windows file separator (Minestom#23) --------- Co-authored-by: DasBabyPixel <43410952+DasBabyPixel@users.noreply.github.com>
theEvilReaper
force-pushed
the
feature/1.21
branch
from
June 25, 2024 10:28
c7b14b8
to
45c6298
Compare
TheMeinerLP
requested changes
Jun 25, 2024
@@ -14,7 +14,7 @@ public JsonArray generate() { | |||
JsonObject dyeColor = new JsonObject(); | |||
dyeColor.addProperty("id", dC.getId()); | |||
dyeColor.addProperty("name", dC.name()); | |||
dyeColor.addProperty("textureDiffuseColor", convertTextureDiffuseColors(dC.getTextureDiffuseColors())); | |||
dyeColor.addProperty("textureDiffuseColor", dC.getTextureDiffuseColor() & 0xFFFFFF); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that right ?
DataGenerator/src/main/java/net/minestom/generators/EntityGenerator.java
Show resolved
Hide resolved
DataGenerator/src/main/java/net/minestom/generators/FeatureFlagGenerator.java
Show resolved
Hide resolved
TheMeinerLP
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The pull request updates the data generator to the Minecraft version 1.21