Skip to content

Commit

Permalink
- Fixed "async" script src issue issue
Browse files Browse the repository at this point in the history
- Added Notice announcing v3.0.0
  • Loading branch information
marclucraft committed Feb 6, 2024
1 parent 769e5a6 commit 3226baf
Show file tree
Hide file tree
Showing 4 changed files with 35 additions and 14 deletions.
21 changes: 19 additions & 2 deletions onesignal-admin.php
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,6 @@ public static function onesignal_notif_on_post_html_view($post)
jQuery('#onesignal_modify_title_and_content').prop("disabled", true);
jQuery('#onesignal_modify_title_and_content').prop("checked", false).change();
}

})
jQuery('#onesignal_modify_title_and_content').change();
</script>
Expand Down Expand Up @@ -558,13 +557,31 @@ public static function admin_custom_load()
add_action('admin_enqueue_scripts', array(__CLASS__, 'admin_custom_scripts'));

$onesignal_wp_settings = OneSignal::get_onesignal_settings();

function admin_notice_new_release()
{
?>
<script>
document.addEventListener('DOMContentLoaded', function() {
activateSetupTab('setup/0');
});
</script>
<div class="notice notice-info is-dismissible">
<p><strong>OneSignal:</strong> We're working on v3.0.0. This version will use our latest Web SDK, so could have some breaking changes. More information can be seen here: <a href="https://documentation.onesignal.com/docs/wordpress-plugin-30" target="_blank">OneSignal WordPress Plugin – v3.0.0</a>.</p>
</div>
<?php
}

add_action('admin_notices', 'admin_notice_new_release');


if (
$onesignal_wp_settings['app_id'] === '' ||
$onesignal_wp_settings['app_rest_api_key'] === ''
) {
function admin_notice_setup_not_complete()
{
?>
?>
<script>
document.addEventListener('DOMContentLoaded', function() {
activateSetupTab('setup/0');
Expand Down
16 changes: 8 additions & 8 deletions onesignal.php
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
* Plugin Name: OneSignal Push Notifications
* Plugin URI: https://onesignal.com/
* Description: Free web push notifications.
* Version: 2.4.2
* Version: 2.4.3
* Author: OneSignal
* Author URI: https://onesignal.com
* License: MIT
Expand All @@ -19,14 +19,14 @@
define('ONESIGNAL_API_RATE_LIMIT_SECONDS', 1);
define('ONESIGNAL_URI_REVEAL_PROJECT_NUMBER', 'reveal_project_number=true');

require_once plugin_dir_path(__FILE__).'onesignal-utils.php';
require_once plugin_dir_path(__FILE__).'onesignal-admin.php';
require_once plugin_dir_path(__FILE__).'onesignal-public.php';
require_once plugin_dir_path(__FILE__).'onesignal-settings.php';
require_once plugin_dir_path(__FILE__).'onesignal-widget.php';
require_once plugin_dir_path(__FILE__) . 'onesignal-utils.php';
require_once plugin_dir_path(__FILE__) . 'onesignal-admin.php';
require_once plugin_dir_path(__FILE__) . 'onesignal-public.php';
require_once plugin_dir_path(__FILE__) . 'onesignal-settings.php';
require_once plugin_dir_path(__FILE__) . 'onesignal-widget.php';

if (file_exists(plugin_dir_path(__FILE__).'onesignal-extra.php')) {
require_once plugin_dir_path(__FILE__).'onesignal-extra.php';
if (file_exists(plugin_dir_path(__FILE__) . 'onesignal-extra.php')) {
require_once plugin_dir_path(__FILE__) . 'onesignal-extra.php';
}

add_action('init', ['OneSignal_Admin', 'init']);
Expand Down
10 changes: 7 additions & 3 deletions readme.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ Contributors: OneSignal
Donate link: https://onesignal.com
Tags: push notification, push notifications, desktop notifications, mobile notifications, chrome push, android, android notification, android notifications, android push, desktop notification, firefox, firefox push, mobile, mobile notification, notification, notifications, notify, onesignal, push, push messages, safari, safari push, web push, chrome
Requires at least: 3.8
Tested up to: 6.2
Stable tag: 2.4.2
Tested up to: 6.4
Stable tag: 2.4.3
License: GPLv2 or later
License URI: http://www.gnu.org/licenses/gpl-2.0.html

Expand All @@ -26,7 +26,7 @@ OneSignal’s free plan allows targeting up to 10,000 subscribers with push noti
OneSignal is trusted by over 1.8M+ developers and marketing strategists. We power push notifications for everyone from early stage startups to Fortune 500 Companies, sending over 6 billion notifications per day. It is the most popular push notification plugin on Wordpress with 100,000+ installations.

= Features =
* **Supports Chrome** (Desktop & Android), **Safari** (Mac OS X), **Microsoft Edge** (Desktop & Android), **Opera** (Desktop & Android) and **Firefox** (Desktop & Android) on both HTTP and HTTPS sites.
* **Supports Chrome** (Desktop & Android), **Safari** (Mac OS X), **Microsoft Edge** (Desktop & Android), **Opera** (Desktop & Android) and **Firefox** (Desktop & Android) on HTTPS sites.

* **Automatic Notifications** - Send notifications to followers every time you publish a new post. Or set up a reminder that gets automatically sent to them if they haven’t visited for a few days.

Expand Down Expand Up @@ -64,6 +64,10 @@ OneSignal is trusted by over 1.8M+ developers and marketing strategists. We powe

== Changelog ==

2.4.3 =
- Fixed "async" script src issue issue
- Added Admin Notice announcing work on v3.0.0.

= 2.4.2 =
- Update OneSignal icons

Expand Down
2 changes: 1 addition & 1 deletion views/config.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
</span>
</div>
<div class="ui pointing stackable menu">
<!-- <a class="item" data-tab="setup">Setup</a> -->
<!-- HIDE THIS AS OUTDATED <a class="item" data-tab="setup">Setup</a> -->
<a class="active item" data-tab="configuration">Configuration</a>
</div>
<div class="ui tab borderless shadowless segment" data-tab="setup" style="padding-top: 0; padding-bottom: 0;">
Expand Down

0 comments on commit 3226baf

Please sign in to comment.