Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the eslint version to resolve npm install error #1514

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

emawby
Copy link
Contributor

@emawby emawby commented Apr 19, 2023

Description

One Line Summary

Bump eslint ^6.5.1 to ^7.0.0

Details

There is a peer dependency issue between eslint-config-prettier and eslint ^6.5.1 since eslint-config-prettier requires eslint >=7.0.0

Motivation

npm install is failing and it also caused our set response time github action to fail.

Scope

eslint version

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

There is a peer dependency issue between eslint-config-prettier and eslint ^6.5.1 since eslint-config-prettier requires eslint >=7.0.0
@emawby emawby merged commit fb29c53 into main Apr 19, 2023
jennantilla pushed a commit that referenced this pull request Feb 12, 2024
Update the eslint version to resolve npm install error
jennantilla pushed a commit that referenced this pull request Mar 12, 2024
Update the eslint version to resolve npm install error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants