add mt5 #382
Merged
add mt5 #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
模型单测
Loader单测
|
T5在generator上测试翻译任务测试
|
xiezipeng-ML
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
CPFLAME
reviewed
Sep 15, 2022
| if attention_mask is not None: | ||
| attention_scores = flow.mul(attention_scores, attention_mask) | ||
| attention_scores = attention_scores - 10000.0 * (1 - attention_mask) | ||
| # TODO(xingyu.liao): graph will occur `where_scalar` errors |
CPFLAME
reviewed
Sep 15, 2022
| @@ -75,6 +75,12 @@ def _convert_state_dict(self, flow_state_dict, cfg): | |||
| prefix1 + "decoder.final_layer_norm.weight" | |||
| ) | |||
|
|
|||
| # Convert MT5's lm_head | |||
| if cfg.model_type == "mt5": | |||
There was a problem hiding this comment.
有个疑问是 这个t5_loader.py是放在libai的文件里面的,
但是看这里好像专门支持的是projects下面mt5所写的loader
是不是放到projects/MT5的文件夹下面更为合理一点.
CPFLAME
reviewed
Sep 15, 2022
projects/MT5/layers/embed_layer.py
Outdated
| ) | ||
| ) | ||
| self.init_method(self.weight) | ||
| # FIXME(lxy): Fill padding_idx is not supported in nd_sbp right now. |
CPFLAME
approved these changes
Sep 15, 2022
xiezipeng-ML
requested review from
oneflow-ci-bot
and removed request for
oneflow-ci-bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MT5的0.3.0发布计划
discussions：#380