Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant codes in ModuleDict #5961

Merged
merged 32 commits into from
Aug 21, 2021

Conversation

Flowingsun007
Copy link
Contributor

@Flowingsun007 Flowingsun007 commented Aug 19, 2021

fix module.py的ModuleDict类中的重复多余代码,某些情况下会导致bug:https://github.com/Oneflow-Inc/OneTeam/issues/544

@Flowingsun007 Flowingsun007 changed the title reemove redundant codes in ModuleDict remove redundant codes in ModuleDict Aug 19, 2021
Copy link
Contributor

@daquexian daquexian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

测试是不是可以简单一些,如果没有什么实际内容,只是两个 relu module 组成的 dict 呢

@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 20, 2021 08:27
@Flowingsun007 Flowingsun007 requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 21, 2021 03:12
@oneflow-ci-bot oneflow-ci-bot removed their request for review August 21, 2021 03:13
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 21, 2021 03:13
@oneflow-ci-bot oneflow-ci-bot self-requested a review August 21, 2021 04:14
@github-actions
Copy link
Contributor

CI failed, removing label automerge

@oneflow-ci-bot oneflow-ci-bot removed their request for review August 21, 2021 06:00
@oneflow-ci-bot oneflow-ci-bot removed their request for review August 21, 2021 06:25
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 21, 2021 06:25
@oneflow-ci-bot oneflow-ci-bot self-requested a review August 21, 2021 07:26
@oneflow-ci-bot oneflow-ci-bot requested review from oneflow-ci-bot and removed request for oneflow-ci-bot August 21, 2021 09:03
@github-actions
Copy link
Contributor

Speed stats:
GPU Name: GeForce GTX 1080 

PyTorch resnet50 time: 139.4ms (= 6971.9ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 128.4ms (= 6418.9ms / 50, input_shape=[16, 3, 224, 224], backward is enabled)
Relative speed: 1.09 (= 139.4ms / 128.4ms)

PyTorch resnet50 time: 84.8ms (= 4237.9ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 74.8ms (= 3741.1ms / 50, input_shape=[8, 3, 224, 224], backward is enabled)
Relative speed: 1.13 (= 84.8ms / 74.8ms)

PyTorch resnet50 time: 59.6ms (= 2977.8ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 47.8ms (= 2389.7ms / 50, input_shape=[4, 3, 224, 224], backward is enabled)
Relative speed: 1.25 (= 59.6ms / 47.8ms)

PyTorch resnet50 time: 48.8ms (= 2439.8ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 38.2ms (= 1909.9ms / 50, input_shape=[2, 3, 224, 224], backward is enabled)
Relative speed: 1.28 (= 48.8ms / 38.2ms)

PyTorch resnet50 time: 44.6ms (= 2231.5ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
OneFlow resnet50 time: 36.6ms (= 1827.6ms / 50, input_shape=[1, 3, 224, 224], backward is enabled)
Relative speed: 1.22 (= 44.6ms / 36.6ms)

@oneflow-ci-bot oneflow-ci-bot merged commit 1db8e93 into master Aug 21, 2021
@oneflow-ci-bot oneflow-ci-bot deleted the fix_module_call_parameterdice_error branch August 21, 2021 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants