Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix dim_scatter 0-dim tensor bug #8418

Merged
merged 3 commits into from
Jun 14, 2022
Merged

fix dim_scatter 0-dim tensor bug #8418

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9164144
fix dim_scatter 0-dim tensor bug
BBuf Jun 14, 2022
328f031
Merge branch 'master' into fix_dim_scatter_0dim_tensor_bug
mergify[bot] Jun 14, 2022
28a530e
Merge branch 'master' into fix_dim_scatter_0dim_tensor_bug
mergify[bot] Jun 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions oneflow/user/kernels/dim_scatter_kernels.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,9 @@ class DimScatterKernel final : public user_op::OpKernel {
DimOpIndexNdHelper<IDX_T> output_nd_helper(shape_vec.data(), ndim);

int64_t upper_bound = 0;
if (input_tensor) {
if (input_tensor && input_tensor->shape().NumAxes() > 0) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0-dim tensor的时候访问越界，所以出现了一个非常大的负值

upper_bound = input_tensor->shape().At(dim); // ensure the idx is smaller than upperbound
} else {
} else if (index_tensor->shape().NumAxes() > 0) {
upper_bound = like_tensor->shape().At(dim); // ensure the idx is smaller than upperbound
}

Expand Down