Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ons-tabbar to be hidden when set hideTabs #423

Merged
merged 1 commit into from
Feb 3, 2015

Conversation

atakayama
Copy link
Contributor

hideTabs flag didn't work when tabbar is located on the bottom of the screen

@argelius
Copy link
Contributor

argelius commented Feb 3, 2015

Hello @atakayama ,

Thanks for the pull request!

Before I merge this, could you please provide an example where hideTabs doesn't work?

It seems to work fine in this example:
http://codepen.io/argelius/pen/xbXLjZ

@atakayama
Copy link
Contributor Author

Hello @argelius,

Sorry for lacking information.
As we can see in your example above, exactly tabbar becomes invisible by clicking "hide" button.
However, if any contents exist behind the tabbar, they won't appear.
It's like applying "visibility: hidden" on tabbar element.

In contrast, in the case if the tabbar is located on the top, we can use whole screen when hiding the tabbar.
It works like "display: none".

argelius added a commit that referenced this pull request Feb 3, 2015
Fixed ons-tabbar to be hidden when set hideTabs
@argelius argelius merged commit 409cbdf into OnsenUI:master Feb 3, 2015
@argelius
Copy link
Contributor

argelius commented Feb 3, 2015

I see it now!

Thanks for the fix! I'll merge this.

@atakayama atakayama deleted the tabbarVisibility branch February 3, 2015 03:57
@argelius
Copy link
Contributor

argelius commented Feb 3, 2015

I just realized the change was made in onsenui.js. That file is actually automatically generated, please make changes in the framework directory if you make another pull request.

I've moved the change to the correct place.

@atakayama
Copy link
Contributor Author

Sure, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants