Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add top bar title on app #152

Merged
merged 8 commits into from
Nov 14, 2022
Merged

Add top bar title on app #152

merged 8 commits into from
Nov 14, 2022

Conversation

javierFernandezMendez
Copy link

No description provided.

@javierFernandezMendez javierFernandezMendez self-assigned this Nov 8, 2022
@javierFernandezMendez javierFernandezMendez linked an issue Nov 8, 2022 that may be closed by this pull request
Add top bar on app #150
Closed
2 tasks
@daniel-grana daniel-grana marked this pull request as draft November 9, 2022 09:36
@javierFernandezMendez javierFernandezMendez marked this pull request as ready for review November 9, 2022 11:49
daniel-grana
daniel-grana previously approved these changes Nov 9, 2022
View reviewed changes
tomfacal
tomfacal previously approved these changes Nov 10, 2022
View reviewed changes
patricia-martinez-imatia
patricia-martinez-imatia reviewed Nov 10, 2022
View reviewed changes
Copy link
Contributor

@patricia-martinez-imatia patricia-martinez-imatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some titles contain the word 'component' and others do not, I think that for homogeneity I would remove the word component from the titles

@sonarcloud
Copy link

sonarcloud bot commented Nov 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@javierFernandezMendez javierFernandezMendez merged commit a8c364e into 8.x.x Nov 14, 2022
@javierFernandezMendez javierFernandezMendez deleted the feature/8.x.x-add-top-bar-on-app branch November 14, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-grana daniel-grana daniel-grana approved these changes

@patricia-martinez-imatia patricia-martinez-imatia patricia-martinez-imatia approved these changes

@gonzalo-martinez-imt gonzalo-martinez-imt Awaiting requested review from gonzalo-martinez-imt

@tomfacal tomfacal Awaiting requested review from tomfacal

Assignees

@javierFernandezMendez javierFernandezMendez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add top bar on app
5 participants
@javierFernandezMendez @daniel-grana @gonzalo-martinez-imt @patricia-martinez-imatia @tomfacal