Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Playground fixes #174

Merged
merged 19 commits into from
Mar 16, 2023
Merged

Playground fixes #174

merged 19 commits into from
Mar 16, 2023

Conversation

javierFernandezMendez
Copy link

No description provided.

@javierFernandezMendez javierFernandezMendez self-assigned this Feb 14, 2023
@javierFernandezMendez javierFernandezMendez marked this pull request as ready for review March 9, 2023 13:07
daniel-grana
daniel-grana requested changes Mar 9, 2023
View reviewed changes
src/app/app-routing.module.ts Outdated Show resolved Hide resolved
patricia-martinez-imatia
patricia-martinez-imatia previously approved these changes Mar 10, 2023
View reviewed changes
Copy link
Contributor

@patricia-martinez-imatia patricia-martinez-imatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. This screen break in 1270px resolution

image
2. on the table and list screens no, the configuration button is not aligned with the quickfilter, on the other hand on the grid screens yes

package-lock.json Outdated Show resolved Hide resolved
patricia-martinez-imatia
patricia-martinez-imatia requested changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@patricia-martinez-imatia patricia-martinez-imatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • when you switch from light to dark mode several times the result of the input home is as follows. I don't know what are the steps to reproduce it

image

src/app/shared/example/example.component.scss Show resolved Hide resolved
daniel-grana
daniel-grana previously approved these changes Mar 16, 2023
View reviewed changes
@javierFernandezMendez javierFernandezMendez merged commit 552045b into 8.x.x Mar 16, 2023
@javierFernandezMendez javierFernandezMendez deleted the bugfix/8.x.x-playground-fixes branch March 16, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-grana daniel-grana daniel-grana approved these changes

@patricia-martinez-imatia patricia-martinez-imatia patricia-martinez-imatia approved these changes

@tomfacal tomfacal Awaiting requested review from tomfacal

Assignees

@javierFernandezMendez javierFernandezMendez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@javierFernandezMendez @daniel-grana @patricia-martinez-imatia