Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added collapsible configuration screens #212

Merged
merged 34 commits into from
Apr 26, 2023
Merged

Added collapsible configuration screens #212

merged 34 commits into from
Apr 26, 2023

Conversation

javierFernandezMendez
Copy link

No description provided.

@javierFernandezMendez javierFernandezMendez self-assigned this Mar 31, 2023
@javierFernandezMendez javierFernandezMendez linked an issue Mar 31, 2023 that may be closed by this pull request
Add configuration button in all those screens that have configuration section #182
Closed
@javierFernandezMendez javierFernandezMendez changed the title Added configuration screens sidenav Added collapsible configuration screens Mar 31, 2023
daniel-grana
daniel-grana previously approved these changes Mar 31, 2023
View reviewed changes
patricia-martinez-imatia
patricia-martinez-imatia requested changes Mar 31, 2023
View reviewed changes
Copy link
Contributor

@patricia-martinez-imatia patricia-martinez-imatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All screens with the screen configuration component now have scrolling even though it is not required
image

@javierFernandezMendez
Copy link
Author

All screens with the screen configuration component now have scrolling even though it is not required image

That problem it is solved on this issue: #213

patricia-martinez-imatia
patricia-martinez-imatia requested changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@patricia-martinez-imatia patricia-martinez-imatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Example basic containers

the container example and configuration section should expand to fit the available space
image

  • Example collapsible containers shouldnt display scroll and the example shoud expand

image

  • Example playground, examples gallery and tooltip shouldnt display scroll
    image
    image
    image

@daniel-grana daniel-grana linked an issue Apr 12, 2023 that may be closed by this pull request
The section headers need a left margin in some screens #214
Closed
@javierFernandezMendez javierFernandezMendez merged commit 53642fd into 8.x.x Apr 26, 2023
@javierFernandezMendez javierFernandezMendez deleted the feature/8.x.x-add-configuration-screens branch April 26, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-grana daniel-grana daniel-grana approved these changes

@patricia-martinez-imatia patricia-martinez-imatia patricia-martinez-imatia approved these changes

@gonzalo-martinez-imt gonzalo-martinez-imt Awaiting requested review from gonzalo-martinez-imt

@tomfacal tomfacal Awaiting requested review from tomfacal

Assignees

@javierFernandezMendez javierFernandezMendez

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@javierFernandezMendez @daniel-grana @patricia-martinez-imatia