Force the user to specify a purpose for the validator script #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusfrost
reviewed
Mar 31, 2023
opshin/__main__.py
Outdated
Comment on lines
141
to
146
| a.add_argument( | ||
| "purpose", | ||
| type=str, | ||
| choices=Purpose.__members__.keys(), | ||
| help="The intended script purpose. Determines the number of parameters.", | ||
| ) |
There was a problem hiding this comment.
Should we make the default purpose spending or always force a choice? What is the current assumption of purpose? Can we display the number of parameters / which ones are necessary in the help text?
There was a problem hiding this comment.
The default purpose currently is "any". I think forcing a choice is necessary otherwise people will just default to not specifying anything and bump into this issue later.
good idea to display the number of parameters for each purpose in the help text!
nielstron
force-pushed
the
feat/specify_purpose
branch
from
3811636
to
839ad0d
Compare
|
This depends on Python-Cardano/pycardano#194 and a solution to the hashing problem of #117 |
nielstron
force-pushed
the
feat/specify_purpose
branch
from
839ad0d
to
9a2a737
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make sure that (likely) mistakes as in OpShin/opshin-pioneer-program#25 are caught by the compilation script.
Leaves an option to circumvent the check.