-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make isinstance more powerful #220
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tested this in https://github.com/OpShin/opshin-pioneer-program with no issues |
No, I also don't see conflicts in any of my code. Appreciate the changes! @nielstron |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a number of improvements for isinstance handling
x.bar if isinstance(x, A) else ...
now worksisinstance(x, A) and x.bar
now works (shortcut expression, leftand
ensures type is valid in the right part)isinstance(x, A) or x.foo
now works (shortcut expression, leftor
ensures type is invalid in the right part)while isinstance(x, A): print(x.bar)
now worksassert isinstance(x, A); print(x.bar)
now worksif isinstance(x, A): ... else: x.foo
now works where x is cast to inverted in the else branchisinstance(x, A) and isinstance(y, B) and x.foo == y.bar
now worksisinstance(x, A) or isinstance(x, B)
now casts x to Union[A, B]. note thatisinstance(x, A) or isinstance(x, B) or whatever
does not cast to anything since no type is actually guaranteed.not isinstance(x, A)
now casts Union[A, B, ...] to Union[B, ...]and
,or
andnot
work in arbitrary and recursive combinationNote: This introduces a breaking change
While the below worked previously, this will break from this change onwards. The reason is that x is casted to "whatever union does not contain A" implicitly in the else branch and this can not be overwritten. Pulling in opinions on whether this will break real-life usecases from @juliusfrost @chrissiwaffler