Do not create RTE_Components.h if no component is selected (#926) #1527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…S-Pack#926) * Do not create RTE_Components.h if no component is selected * [projmgr] Do not emit reference to `RTE_Components.h` when it does not exist --------- Co-authored-by: Daniel Brondani <daniel.brondani@arm.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1527 +/- ##
=======================================
Coverage 63.36% 63.36%
=======================================
Files 162 162
Lines 30910 30911 +1
Branches 18943 18944 +1
=======================================
+ Hits 19586 19587 +1
- Misses 7521 7523 +2
+ Partials 3803 3801 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Test Results 7 files 53 suites 4m 50s ⏱️ Results for commit da13431. ♻️ This comment has been updated with latest results. |
|
I'm not sure that this requirement is correct. There is a define "cmsis_device_header" in RTE_components.h that should be also there when no component is selected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not create RTE_Components.h if no component is selected
[projmgr] Do not emit reference to
RTE_Components.hwhen it does not existCo-authored-by: Daniel Brondani daniel.brondani@arm.com