GitHub actions #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charles Oliveira <charles.oliveira@linaro.org>
Signed-off-by: Charles Oliveira <charles.oliveira@linaro.org>
|
Looks really good! One suggestion: Use the https://github.com/sirupsen/logrus/blob/master/.github/workflows/ci.yaml |
|
Once you merge this I will help add some more linters that are disabled by default but very useful as well! |
chaws
force-pushed
the
github-actions
branch
5 times, most recently
from
4ec4c3d
to
64961ac
Compare
Signed-off-by: Charles Oliveira <charles.oliveira@linaro.org>
Signed-off-by: Charles Oliveira <charles.oliveira@linaro.org>
|
Thanks @jscook2345 ! I've incorporated your suggestions and also split the thing into 3 jobs: lint, format and coverage (which runs tests). I'm merging this now so that next PR's will run through the checks. Will be waiting for more linters :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shows how Github actions CI ensures code quality by running tests, lint and format-checking.