fixing missing label in add_dimension of tuw pol uc #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-mohr
reviewed
Jul 8, 2020
docs/s1-uc1-polarization.json
Outdated
| @@ -81,7 +91,8 @@ | |||
| "from_node": "cr" | |||
| }, | |||
| "name": "bands", | |||
| "type": "bands" | |||
| "type": "bands", | |||
| "label": 0 | |||
There was a problem hiding this comment.
Can't you directly use the label name "B" and then remove the rename_label_cr node?
There was a problem hiding this comment.
@m-mohr : Yes, good idea, with the new label parameter this would be the best solution!
There was a problem hiding this comment.
Yes agree, I tried that and at the moment this fails at the GEE backend, I think because "add_dimension" does not set the label to the GEE object yet, but just in the JS metadata.
There was a problem hiding this comment.
Yes I am on it right now. Should I make a new pull request, or can I just add it here ?
There was a problem hiding this comment.
Can be part of this PR, but whatever you prefer.
|
Haven't checked in detail, but seems okay. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix in the examples process graph (now required "label" attribute was missing in add_dimension)