-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to general data cube definition #382
Conversation
f5c18eb
to
90cb52f
Compare
For another issue: Should we change the vector_ prefix for the vector-related processes to something else? Edit: Thinking a bit more about it, I think vector_ is fine. We still have a vector data cube as input, only the dimension is using the geometry terminology. As the prefixes do usually reflect the type of data you are passing in (i.e. vector data cube), we can stick with the names. Also to preserve a bit of backward compatibility with some rare implementations. |
Also: let's move that question to another issue, to unblock #382 |
This is also ready for final review. I hope that I have fixed all open issues sufficiently. If you see minor things that we can fix quickly, please mention them here. If you see larger issues to be discussed, maybe open a separate issue so that we can merge this and then work in smaller PRs that are easier to handle. Additionally, the schema for vector data cubes has changed due to the changes in the other PRs (API, STAC etc.):
So the type is now @soxofaan @mkadunc @aljacob @clausmichele @jdries @dthiex @LukeWeidenwalker @pierocampa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks all good to me. My only concern would also be about the plural of geometries and bands, it would be cleaner to have both in singular, but it is nothing that is a big issue after all, at least these two are consistant then, as I guess it would be quite the effort for everyone to go from bands to band as well.
@aljacob The naming is discussed in another issue: Open-EO/openeo-api#479 |
This goes through the existing processes and makes changes so that, if applicable, they work with vector cubes.
Tasks:
Add guidelines how geojson should be converted into a vector-cube (as we have geojson as input data type it might be the only file format for which we describe the actual import procedure)-> I'll keep this as a separate PR, tracked by process to convert inline GeoJSON to a vector cube #346