Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connection.execute(): only JSON-decode when response is JSON #499

Closed
soxofaan opened this issue Nov 8, 2023 · 2 comments
Closed

connection.execute(): only JSON-decode when response is JSON #499

soxofaan opened this issue Nov 8, 2023 · 2 comments
Assignees
@VictorVerhaert
Labels
feature request good first issue low hanging fruit usability

Comments

@soxofaan
Copy link
Member

soxofaan commented Nov 8, 2023

In #498 a user used con.execute() trying to get a GeoTIFF, but that failed because con.execute() is doing JSON decoding by default:

openeo-python-client/openeo/rest/connection.py

Line 1578 in d1e77e2

).json() # TODO: only do JSON decoding when mimetype is actually JSON?

this should only be done if response mime type is actually JSON.
And return raw bytes otherwise?
VictorVerhaert added a commit that referenced this issue Jan 18, 2024
@VictorVerhaert
catch json decode errors in connection.execute
b6d6099 
github issue #499
added try/except to connection.execute to catch json decode errors
If a json decode error occurs, the response is return raw
@VictorVerhaert VictorVerhaert mentioned this issue Jan 18, 2024
Merged
@VictorVerhaert
Copy link
Contributor

Added a simple try/catch approach. However not quite sure how to test this.

VictorVerhaert added a commit that referenced this issue Jan 19, 2024
@VictorVerhaert
added parameter auto_decode to Connection.execute()
a8abe5f 
github issue #499
VictorVerhaert added a commit that referenced this issue Jan 29, 2024
@VictorVerhaert
execute logs warning when decoding fails
fabeaae 
github issue #499
auto_decode argument added to datacube.execute
VictorVerhaert added a commit that referenced this issue Jan 29, 2024
@VictorVerhaert
added tests for datacube.execute
ac0ec28 
github issue #499
VictorVerhaert added a commit that referenced this issue Jan 30, 2024
@VictorVerhaert
nested JSONDecode error in OpenEoClientError
fc33532 
Issue #499
VictorVerhaert added a commit that referenced this issue Jan 30, 2024
@VictorVerhaert
added regex to error test
59dd84d 
issue #499
VictorVerhaert added a commit that referenced this issue Jan 30, 2024
@VictorVerhaert
added type check for raw response
ba6ee0a 
issue #499
VictorVerhaert added a commit that referenced this issue Jan 30, 2024
@VictorVerhaert
added param documentation to datacube.execute()
73279a7 
issue #499
VictorVerhaert added a commit that referenced this issue Feb 2, 2024
@VictorVerhaert
minor finetuning
2ce9d3b 
issue #499
VictorVerhaert added a commit that referenced this issue Feb 2, 2024
@VictorVerhaert
added entrie to CHANGELOG.md
c63eb75 
issue #499
@soxofaan
Copy link
Member Author

soxofaan commented Feb 7, 2024

fixed by #529

@soxofaan soxofaan closed this as completed Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VictorVerhaert VictorVerhaert

Labels
feature request good first issue low hanging fruit usability
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@soxofaan @VincentVerelst @VictorVerhaert