Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate GeometryCollection in favor of FeatureCollection (e.g. DelayedVector) #71

Open
soxofaan opened this issue May 25, 2021 · 5 comments

Comments

@soxofaan
Copy link
Member

soxofaan commented May 25, 2021

see Open-EO/openeo-processes#253:

In VITO backend code we use GeometryCollection as a collection of separate geometries, for which separate aggregations should be calculated for example. In Open-EO/openeo-processes#253 there is discussion to deprecate GeometryCollection usage as much as possible and promote FeatureCollections instead.

In DelayedVector (and other places) we do things the other way around at the moment: when we get a FeatureCollection, we convert it to a GeometryCollection.

Changing this will probably cause some nuisance, e.g. in the interaction between geopyspark driver and in UDFs that depend on this behavior.

@soxofaan
Copy link
Member Author

soxofaan commented Jun 1, 2021

FYI: Open-EO/openeo-processes#253 has been merged, so now it's "official" that GeometryCollections have to be considered to be a single geometry, and that FeatureCollections have to be used to aggregate over separate geometries.

@soxofaan
Copy link
Member Author

soxofaan commented Jun 1, 2021

(internal ticket/ref: EP-3893)

@soxofaan
Copy link
Member Author

Also see: Open-EO/openeo-processes#270

@soxofaan soxofaan added the API label Nov 3, 2021
@soxofaan
Copy link
Member Author

related to EP-3981 (add vector cube support) too

@soxofaan
Copy link
Member Author

soxofaan commented Jun 7, 2024

related: MultiPolygon should also not be (ab)used as a collection of geometries: #288

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant