Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookbook #36

Merged
merged 15 commits into from
Apr 30, 2021
Merged

Cookbook #36

merged 15 commits into from
Apr 30, 2021

Conversation

m-mohr
Copy link
Member

@m-mohr m-mohr commented Apr 20, 2021

Opened this PR to make some comments...

package.json Outdated Show resolved Hide resolved
.vuepress/config.js Outdated Show resolved Hide resolved
@m-mohr
Copy link
Member Author

m-mohr commented Apr 20, 2021

We can merge the cookbook on a chapter-by-chapter basis, so once you have the first things ready we can merge and then work more agile and just release each chapter once finished. We don't need to wait until you've done "everything".

@jonathom
Copy link
Member

CodeSwitcher doesn't work for me anymore. Simply no code is displayed when npm run dev, even with a fresh npm i. Can you confirm @m-mohr?

@m-mohr
Copy link
Member Author

m-mohr commented Apr 22, 2021

It worked for me, but I had to do a fresh install (i.e. remove package-lock.json and node_modules and then npm i) for whatever reason.

@jonathom
Copy link
Member

I'm not done with all output types yet, but the basic structure of a first chapter is there. Have a look if you want :)

jonathom and others added 2 commits April 23, 2021 15:12
Co-authored-by: Matthias Mohr <m.mohr@uni-muenster.de>
@jonathom
Copy link
Member

jonathom commented Apr 29, 2021

When running this branch locally, no processes documentation is shown (the page loads, but no processes are there). Is this by design (idk how the doc works)?

@m-mohr
Copy link
Member Author

m-mohr commented Apr 29, 2021

That's a known issue in dev mode, indeed.

@jonathom jonathom marked this pull request as ready for review April 29, 2021 16:12
@jonathom
Copy link
Member

added text output. Kindly check one more time and let me know if there's something to fix / whether I can merge :)

jonathom and others added 2 commits April 30, 2021 11:18
Co-authored-by: Matthias Mohr <m.mohr@uni-muenster.de>
@jonathom jonathom merged commit bcdf9a1 into master Apr 30, 2021
@m-mohr
Copy link
Member Author

m-mohr commented Apr 30, 2021

Great, looks good :-)

@jonathom jonathom deleted the cookbook branch May 3, 2021 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants