-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: New UI for option in topview & sideview #2407
feat: New UI for option in topview & sideview #2407
Conversation
The PathPlotter needs to have your new options now. |
@ReimarBauer @joernu76 can you take a look plz, does it seems good? can i move on to the next thing? |
@rohit2p the remote sensing bug will be fixed soon but the flake8 is yours |
@ReimarBauer @joernu76 can you take a look i am implemented line thickness, transparency of lines, dashed lines option in topview option they are working but the problem is the value is getting stored in settings but when i restart the application the map plot doesn't reload according to the saved value in settings. can you suggest me something how can fix this also does my implementation looks correct to you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -336,7 +336,7 @@ class PathPlotter: | |||
def __init__(self, ax, mplpath=None, | |||
facecolor='blue', edgecolor='yellow', | |||
linecolor='blue', markerfacecolor='red', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when you want to keep the stored values you need to use them here. Here you initialize the new line with a thickness of 2.
Edit: We are not using msui-core.conf currently to restore the used values. They persists only in a session. This means we have to look on redraw functionality
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have a look on redraw_path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and set_settings in mpl_qtwidget there we use the other options for initializing them on e.g. a second topview.
I just tried out your UI_element_in_option branch. Should it work, currently? |
First try
|
When I open Topview or Sideview I get example.mp4 |
def set_line_style(self, style): | ||
"""Set the style of the line representing the flight track.""" | ||
line_style_dict = self.plotter.get_line_style_dict() | ||
if style in line_style_dict: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mmh. Should it happen that a style is not contained in the dict?
* UI and line thickness * line thickness working * every new feature working in option * Ui of the sideview * topview completely done without the ok * both topview and sideview working * key error fixed * key error fixed in sideview * ATQ feedback change UI
Purpose of PR?:
This PR contain new UI for option in topview & sideview with more features.
Checklist: