Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed some bugs in the html code #174

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

jesutobi
Copy link
Contributor

@jesutobi jesutobi commented Oct 15, 2022

fixes #33
@alswajiab @BatoolMM i discovered some bugs in the html code, that could be a serious bug in some cases,

on line 162, line 227, line 205, line210, line 227 , line 489
i have fixed it and this is my pull request

@netlify
Copy link

netlify bot commented Oct 15, 2022

Deploy Preview for oscksa ready!

Name Link
🔨 Latest commit 49d7032
🔍 Latest deploy log https://app.netlify.com/sites/oscksa/deploys/635a4069315ccc000973e43e
😎 Deploy Preview https://deploy-preview-174--oscksa.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@BatoolMM BatoolMM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this @jesutobi!

Can you fix the conflicts and reflect the same changes on the Arabic page, please?

@alswajiab can you check deeply preview, it's not working with me, is it working with you in this PR?

@jesutobi
Copy link
Contributor Author

@BatoolMM i have resolved the conflicts and made same changes into the ar-index.html file

@jesutobi
Copy link
Contributor Author

@BatoolMM i have resolved the recent conflicts that i was notified of

@jesutobi
Copy link
Contributor Author

@BatoolMM Goodmorning , i was notified of a new conflict today which i just resolved and commited

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixing tags in the HTML
2 participants