duplicate ID #182
Open
duplicate ID #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oscksa ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Hello @alswajiab and @BatoolMM I created a pull request for duplicate id names for the funders section and the contact section which both had the same id 'contact' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The ID for two sections is the same (contact).
The ID for the contact section is the same as the ID for the funders section (contact).
Because they share the same ID, the page scrolls to the Funders section when "Contact" is clicked on the navigation menu.
This PR Fixes #<181>
List of changes proposed in this PR (pull-request)
What should a reviewer concentrate their feedback on?