-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix alt attributes in image tags on OSCSA Website main page #217
Open
AminMusah
wants to merge
15
commits into
Open-Science-Community-Saudi-Arabia:main
Choose a base branch
from
AminMusah:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix alt attributes in image tags on OSCSA Website main page #217
AminMusah
wants to merge
15
commits into
Open-Science-Community-Saudi-Arabia:main
from
AminMusah:main
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merging changes in faqs.txt
merging changes in faqs.txt
✅ Deploy Preview for oscksa ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Hi @BatoolMM I am done with this task. Please kindly review. Thanks. |
Thank you for this PR @AminMusah - can you remove |
@BatoolMM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some of the image tags used in the website do not have an alt attribute which provides alternative information for an image if a user for some reason cannot view it (because of slow connection, an error in the src attribute, or if the user uses a screen reader).
Fixes #197
List of changes proposed in this PR (pull-request)
What should a reviewer concentrate their feedback on?