Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alt attributes in image tags on OSCSA Website main page #217

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

AminMusah
Copy link

Summary

Some of the image tags used in the website do not have an alt attribute which provides alternative information for an image if a user for some reason cannot view it (because of slow connection, an error in the src attribute, or if the user uses a screen reader).

Fixes #197

List of changes proposed in this PR (pull-request)

    • Add alt attribute in image tags.

What should a reviewer concentrate their feedback on?

  • Everything looks ok?

@netlify
Copy link

netlify bot commented Oct 26, 2022

Deploy Preview for oscksa ready!

Name Link
🔨 Latest commit 83d1c32
🔍 Latest deploy log https://app.netlify.com/sites/oscksa/deploys/635fc56eb42d4c00089b4437
😎 Deploy Preview https://deploy-preview-217--oscksa.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@AminMusah
Copy link
Author

Hi @BatoolMM I am done with this task. Please kindly review. Thanks.

@BatoolMM
Copy link
Member

Thank you for this PR @AminMusah - can you remove fasq.txt, please?

@AminMusah
Copy link
Author

@BatoolMM fasq.txt has been removed. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing alt attribute in some image tags in the OSCSA website
2 participants