Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data import: Invalid units in column headers are not properly handled #982

Closed
abdelr opened this issue Apr 29, 2021 · 0 comments · Fixed by #986
Closed

Data import: Invalid units in column headers are not properly handled #982

abdelr opened this issue Apr 29, 2021 · 0 comments · Fixed by #986
Assignees
@abdelr
Labels
Importer-Redesign Redesign of observed data import

Comments

@abdelr
Copy link
Member

abdelr commented Apr 29, 2021

@Yuri05 commented on Mon Apr 26 2021

004_TC_InvalidUnit.xlsx
grafik

After import:
grafik

@PavelBal commented on Wed Apr 28 2021

Every dimension (or unit) that is not in the OSPS-Dimensions should be considered as invalid and the import is not possible until the user (manually) sets the unit.
@abdelr abdelr mentioned this issue Apr 29, 2021
Closed
@abdelr abdelr self-assigned this Apr 29, 2021
@abdelr abdelr added the Importer-Redesign Redesign of observed data import label Apr 29, 2021
abdelr added a commit that referenced this issue Apr 29, 2021
@abdelr
Do not accept invalid units #982
773b06f
@abdelr abdelr mentioned this issue Apr 29, 2021
Merged
@abdelr abdelr linked a pull request Apr 29, 2021 that will close this issue
Do not accept invalid units #982 #986
Merged
msevestre pushed a commit that referenced this issue Apr 29, 2021
@abdelr
Do not accept invalid units #982 (#986)
062aa03 
* Do not accept invalid units #982

* better using dimension factory to check if the unit exists
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abdelr abdelr

Labels
Importer-Redesign Redesign of observed data import
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not accept invalid units #982 Open-Systems-Pharmacology/OSPSuite.Core
1 participant
@abdelr