Do not accept invalid units #982 #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yuri05
approved these changes
Apr 29, 2021
msevestre
reviewed
Apr 29, 2021
| @@ -39,6 +44,7 @@ protected override UnitDescription ExtractUnits(string description, IUnformatted | |||
| .Substring(1, units.Length - 2) //remove the brackets | |||
| .Trim() //remove whitespace | |||
| .Split(',') //split comma separated list | |||
| .Where(unitName => _dimensionFactory.Dimensions.SelectMany(dimension => dimension.Units).Any(unitFromDimension => unitFromDimension.Name == unitName)) //only accepts valid units | |||
There was a problem hiding this comment.
I do not think this is correct here. We have a lot of methods checking whether a unit is valid or not (taking care of case, synonyms etc...)
This needs to change
msevestre
requested changes
Apr 29, 2021
msevestre
reviewed
Apr 29, 2021
| @@ -39,6 +44,7 @@ protected override UnitDescription ExtractUnits(string description, IUnformatted | |||
| .Substring(1, units.Length - 2) //remove the brackets | |||
| .Trim() //remove whitespace | |||
| .Split(',') //split comma separated list | |||
| .Where(unitName => _dimensionFactory.DimensionForUnit(unitName) != null) //only accepts valid units | |||
There was a problem hiding this comment.
The same logic should be used for other unit recognition by the way (in column headeR)
Is this the case @abdelr and @georgeDaskalakis
msevestre
reviewed
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not accept invalid units #982