Add unit tests #64
Merged
Add unit tests #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In the case that the game id is non-numeric and store isn't set to 'umu', gamefixes-umu wouldn't be searched for a fix.
Removes the relative import syntax to avoid an ImportError when running the unit test
- In order to run unit tests for the protonfix modules, it seems relative imports cannot be used when referencing the modules relative to the project directory as an ImportError will occur. Since relative imports are necessary for running protonfixes in Proton, we need to keep them and handle the exception by importing normally.
- In the case that the store is set and the game id is numeric, no steam game fixes will be referenced
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #59
Adds unit tests for
fix.py, the module responsible for applying user fixes.