Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQ] Expose all top-level config options as properties #2962

Closed
InfoSec812 opened this issue May 21, 2019 · 3 comments · Fixed by #2963
Closed

[REQ] Expose all top-level config options as properties #2962

InfoSec812 opened this issue May 21, 2019 · 3 comments · Fixed by #2963

Comments

@InfoSec812
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Some of the options in the CodeGenMojo are exposed such that you can pass the property on the Maven command-line using -Dopenapi.generator.maven.plugin.<property>, but not all. I propose that ALL of those properties should be exposed and that the documentation should be updated to reflect the property name as well.

Describe the solution you'd like

Modify the CodeGenMojo to include property exposure in all @parameter annotations

Describe alternatives you've considered

None that I can think of

Additional context

I can submit a PR for this if it is helpful.

@wing328
Copy link
Member

wing328 commented May 21, 2019

@InfoSec812 thanks for the suggestion.

@jimschubert has been performing some works to enhance/refactor the options: #2946

Please review and let us know if you've any feedback

@InfoSec812
Copy link
Contributor Author

@InfoSec812 thanks for the suggestion.

@jimschubert has been performing some works to enhance/refactor the options: #2946

Please review and let us know if you've any feedback

@wing328 The CodeGenMojo is not addressed in that change, but I have just submitted a PR which addresses exposing the CodeGenMojo configuration settings as properties where appropriate and updated the README to make it clear how it works.

@jimschubert
Copy link
Member

The changes in #2946 shouldn't have an effect on the public api usage of CodegenConfigurator (which I'm assuming was the concern).

Glancing over the PR, it looks like a maven specific way of defining settings as properties rather than configuration. I agree there shouldn't be any overlap between the two

wing328 pushed a commit that referenced this issue May 31, 2019
* Resolves #2962 - Add properties config to Maven parameters

* Fixed formatting

* Fixed formatting

* Fix missing hyphen

* Added propery for `engine` parameter
jimschubert added a commit to jimschubert/openapi-generator that referenced this issue Jun 5, 2019
* 4.1.x: (56 commits)
  sync master
  Update compatibility table
  Ruby client: escape path parameters (OpenAPITools#3039)
  [gradle plugin] Release 4.0.1 fixes (OpenAPITools#3051)
  Update version to 4.0.2-SNAPSHOT (OpenAPITools#3047)
  Map number to double time since float is also parsed as double in Qt5 C++ (OpenAPITools#3046)
  Prepare 4.0.1 release (OpenAPITools#3041)
  [gradle] Reworking publishing pipeline (OpenAPITools#2886)
  [typescript-fetch] Fix uploading files (OpenAPITools#2900)
  Resolves OpenAPITools#2962 - Add properties config to Maven parameters (OpenAPITools#2963)
  fix(golang): Check error of xml Encode (OpenAPITools#3027)
  [C++][Restbed] Add handler callback methods (OpenAPITools#2911)
  Remove null checks for C# value types (OpenAPITools#2933)
  [python-server] Support python 3.7 for all server-generators (OpenAPITools#2884)
  Use golang's provided method names (gin) (OpenAPITools#2983)
  [python] Adding constructor parameters to Configuration and improving documentation (OpenAPITools#3002)
  Add new option to maven plugin's readme (OpenAPITools#3025)
  Engine param in maven plugin. (OpenAPITools#2881)
  Added support for patterns on model properties (OpenAPITools#2948)
  [csharp] Make API response headers dictionary case insensitive (OpenAPITools#2998)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants