Update version to 4.0.2-SNAPSHOT #3047
Conversation
| @@ -50,6 +49,8 @@ build_script: | |||
| - msbuild samples\client\petstore\csharp\OpenAPIClientNetStandard\Org.OpenAPITools.sln /logger:"C:\Program Files\AppVeyor\BuildAgent\Appveyor.MSBuildLogger.dll" | |||
| # install openapi-generator locally | |||
| - mvn clean install --quiet | |||
| # run the locally installed openapi-generator-gradle-plugin | |||
| - gradle -PopenApiGeneratorVersion=4.0.2-SNAPSHOT -b modules\openapi-generator-gradle-plugin\samples\local-spec\build.gradle buildGoSdk --info | |||
There was a problem hiding this comment.
I think -PopenApiGeneratorVersion=4.0.2-SNAPSHOT can be removed after changes to fix release_version_update.sh and release_version_update_docs.sh
| @@ -18,7 +18,7 @@ | |||
| <plugin> | |||
| <groupId>org.openapitools</groupId> | |||
| <artifactId>openapi-generator-maven-plugin</artifactId> | |||
| <version>4.0.0</version> | |||
There was a problem hiding this comment.
This file was previously not being updated, which is why there's a jump from 4.0.0 to 4.0.2-SNAPSHOT in this PR.
There was a problem hiding this comment.
Updated the release checklist to include this file: https://github.com/OpenAPITools/openapi-generator/wiki/Release-Checklist
There was a problem hiding this comment.
It really depends what we would like to do.
I like when documentation and usage examples (maven & gradle) use the last released version. But we can do it an other way in this project.
If we use the current SNAPSHOT version, at least we should add this at the top of the pom:
<pluginRepositories>
<pluginRepository>
<id>sonatype-snapshots</id>
<url>https://oss.sonatype.org/content/repositories/snapshots/</url>
</pluginRepository>
</pluginRepositories>in order for the users to be able to try the lib without having to compile the plugin locally them-self.
(and add of course the equivalent for the gradle examples)
There was a problem hiding this comment.
I've added the pluginRepository config to the maven plugin's examples which are referenced in the release_version_update_docs.sh script:
java-client.xml
multi-module/java-client/pom.xml
non-java-invalid-spec.xml
non-java.xml
I think it would make sense for documentation to always reference a major version, but I think samples in the repository should probably reference the current version of the repository. That is, maven examples are the same as everything under ./samples, since they're examples of how the maven plugin works. I would personally think it was a bug if if I found an example in another repository that didn't track the same version of the repository.
I don't feel too strongly about this, though.
* 4.1.x: (56 commits) sync master Update compatibility table Ruby client: escape path parameters (OpenAPITools#3039) [gradle plugin] Release 4.0.1 fixes (OpenAPITools#3051) Update version to 4.0.2-SNAPSHOT (OpenAPITools#3047) Map number to double time since float is also parsed as double in Qt5 C++ (OpenAPITools#3046) Prepare 4.0.1 release (OpenAPITools#3041) [gradle] Reworking publishing pipeline (OpenAPITools#2886) [typescript-fetch] Fix uploading files (OpenAPITools#2900) Resolves OpenAPITools#2962 - Add properties config to Maven parameters (OpenAPITools#2963) fix(golang): Check error of xml Encode (OpenAPITools#3027) [C++][Restbed] Add handler callback methods (OpenAPITools#2911) Remove null checks for C# value types (OpenAPITools#2933) [python-server] Support python 3.7 for all server-generators (OpenAPITools#2884) Use golang's provided method names (gin) (OpenAPITools#2983) [python] Adding constructor parameters to Configuration and improving documentation (OpenAPITools#3002) Add new option to maven plugin's readme (OpenAPITools#3025) Engine param in maven plugin. (OpenAPITools#2881) Added support for patterns on model properties (OpenAPITools#2948) [csharp] Make API response headers dictionary case insensitive (OpenAPITools#2998) ...
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master,4.1.x,5.0.x. Default:master.Description of the PR
(details of the change, additional tests that have been done, reference to the issue for tracking, etc)