Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typescript node default enum #12633

Merged

Conversation

GuyGitzMagen
Copy link
Contributor

@GuyGitzMagen GuyGitzMagen commented Jun 18, 2022

  • Default enum value and type are seperated by .
  • classname is added to enum default property

This is a fix for the bug mentioned here #12634.
I changed the default enum value to be ., and edited model.mustache template accordingly.
For testing I used the following yaml schema and generation command. I made sure that before the fix the client wasn't generated correctly and that the problem was solved after the fix.

Fixes #12634

Opeanapi schema:

openapi: "3.0.0"
info:
  version: "1.0.0"
  title: "Test default enum value"
paths:
  /eat:
    post:
      requestBody:
        content:
          application/json:
            schema:
              $ref: "#/components/schemas/Fruit"
      responses:
        200:
          description: "Yummy"

components:
  schemas:
    Fruit:
      type: "object"
      properties:
        fruit:
          type: "string"
          enum: [
              "melon",
              "apple"
            ]
          default: "apple"

Generation command:

openapi-generator-cli generate -g typescript-node -i openapi.yml --additional-properties=npmName=example

Committee mentions: @TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov @davidgamero @mkusaka

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.0.1) (patch release), 6.1.x (breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@GuyGitzMagen GuyGitzMagen force-pushed the fix-typescript-node-default-enum branch from 8fd4973 to 9ca700e Compare June 18, 2022 17:53
Copy link
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macjohnny macjohnny merged commit decb96b into OpenAPITools:master Jun 20, 2022
@wing328 wing328 added this to the 6.0.1 milestone Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG][typescript-node] Default enum value in object is generated in a bad way
3 participants