[csharp] Changed enums to start from 0 #15503
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have some enumerations with "Unknown" as a valid option. The generated code was giving this enum a value of 1. This is a bit unusual, I would expect this value to be 0. To solve this, I've added logic to allow the enum to be zero based if "Unknown" (case insensitive) is the first option, or if the enum is marked as x-zero-based-enum, or if the user adds zeroBasedEnum=true to the additional properties.
This fixes the issue with a fallback, users can opt out. Also, if the enumeration does not have "Unknown" as the first value, then the enum will still start at 1, giving developers the ability to add unknown as the first option later without messing up the enum values.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(6.3.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks)