Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use substring instead of substr in JavaScript and TypeScript generators #15937

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

possan
Copy link
Contributor

@possan possan commented Jun 27, 2023

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@possan possan changed the title Use substring instead of substr in JavaScript and TypeScript generators Draft: Use substring instead of substr in JavaScript and TypeScript generators Jun 27, 2023
@possan possan marked this pull request as ready for review June 27, 2023 09:55
@possan possan changed the title Draft: Use substring instead of substr in JavaScript and TypeScript generators Use substring instead of substr in JavaScript and TypeScript generators Jun 27, 2023
@wing328
Copy link
Member

wing328 commented Jun 28, 2023

cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04)

cc @CodeNinjai (2017/07) @frol (2017/07) @cliffano (2017/07)

@wing328 wing328 added Client: JavaScript/Node.js Client: TypeScript Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc. labels Jun 28, 2023
Copy link
Contributor

@amakhrov amakhrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

Looks good to me

@wing328 wing328 merged commit 8fe4d78 into OpenAPITools:master Jun 29, 2023
@wing328 wing328 added this to the 7.0.0 milestone Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client: JavaScript/Node.js Client: TypeScript Enhancement: Code Cleanup General refactoring, removal of deprecated things, commenting, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants