-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional reserved words for java and csharp #16276
Add additional reserved words for java and csharp #16276
Conversation
@jwenger100 Thanks for the PR. Can you please run |
FYI. Recently, we've added new options to allow users map property, parameter, model name: https://github.com/OpenAPITools/openapi-generator/blob/master/docs/customization.md#name-mapping I hope you will find these new features useful in your use cases. |
FYI @mandrean (2017/08) @frankyjuang (2019/09) @shibayan (2020/02) @Blackclaws (2021/03) @lucamazzanti (2021/05) @iBicha (2023/07) @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08) |
FYI. documentation updated via 6a8039c |
Hi @wing328 and others, I think a good long-term solution would be to add some code that adds every entry from If you agree, I would create a PR to implement this. Should I target only the Java-based generators then and let maintainers of other generators judge the idea and implement it in their generators themselves? Or should I directly implement it on a higher level so that it applies automatically to all generators? |
thanks for the suggestion. let me think about it and get back to you after the v7.0.0 release. |
I hope you will find these new features useful in your use cases. @wing328 Will this work for API names as well as model names and property names? Thanks for the insight |
Hi @wing328, any new thoughts about this? Or should I ping you again in a few months? :) |
@jwenger100 what do you mean by |
@martin-mfg please go ahead to submit a PR assuming it doesn't need a lot of work. (I'm not against the idea at all. With the mapping option, users can fallback to whatever they want if needed) |
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(6.3.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks)cc
@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)
@mandrean (2017/08) @frankyjuang (2019/09) @shibayan (2020/02) @Blackclaws (2021/03) @lucamazzanti (2021/05) @iBicha (2023/07)