Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JAVA][SPRING] add imports & primitives to reserved words #16713

Open
wants to merge 2 commits into
base: 8.0.x
Choose a base branch
from

Conversation

martin-mfg
Copy link
Contributor

@martin-mfg martin-mfg commented Oct 3, 2023

In Java-based generators, add importMapping().keySet() and languageSpecificPrimitives() to reservedWords.

Because using words from those two lists as class names or variable names causes problems in certain cases.

This is a follow-up to #16276 (comment) . However, after deeper investigation, I deviated a bit from the approach that I originally proposed there.

The addition of more reserved words leads to some variables in the samples code being renamed, e.g. _integer and _dateTime. These didn't cause problems before the renaming actually, because the lowercase variable name "dateTime" doesn't clash with the uppercase class name "DateTime" anyway. But the current reserved words logic (of Java based generators) is case-independend and applies equally to variable names and class names. So in the current setup we can't avoid those unnecessary renamings I think. If you have an idea how to improve this situation, let me know.
Since this slightly changes some public method names in the generated code, I targeted this PR at the 8.0.x branch.
example:

-  public DataQuery date(OffsetDateTime date) {
+  public DataQuery _date(OffsetDateTime _date) {

Regarding the failing java-camel test, please see #18870 (comment) .

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)
    @cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09) @martin-mfg (2023/08)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant