Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] [Vertx] Use pascalcase instead of double lambda #18667

Merged

Conversation

rohitsanj
Copy link
Contributor

Follow up task from #18630, see this comment.

Existing unit test in JavaClientCodeGenTest covers the change in this PR.

@Test
public void testVertXAuthInfoWithHyphenSeparatedSecurityScheme() throws Exception {
Map<String, Object> properties = new HashMap<>();
properties.put(CodegenConstants.API_PACKAGE, "xyz.abcdef.api");
File output = Files.createTempDirectory("test").toFile();
output.deleteOnExit();
final CodegenConfigurator configurator = new CodegenConfigurator()
.setGeneratorName("java")
.setLibrary(JavaClientCodegen.VERTX)
.setAdditionalProperties(properties)
.setInputSpec("src/test/resources/3_0/ping-with-hyphen-separated-security-scheme.yaml")
.setOutputDir(output.getAbsolutePath().replace("\\", "/"));
final ClientOptInput clientOptInput = configurator.toClientOptInput();
DefaultGenerator generator = new DefaultGenerator();
List<File> files = generator.opts(clientOptInput).generate();
// Test that hyphen-separated security scheme names does not
// break the Java VertX client code generation
validateJavaSourceFiles(files);
// Test that the name was correctly transformed to camelCase
// starting with an uppercase letter
TestUtils.assertFileContains(
Paths.get(output + "/src/main/java/xyz/abcdef/ApiClient.java"),
"public static class AuthInfo {",
"public void addHyphenatedNameTestAuthentication(String bearerToken) {",
"public static AuthInfo forHyphenatedNameTestAuthentication(String bearerToken) {"
);
}

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 merged commit ed33b86 into OpenAPITools:master May 14, 2024
14 checks passed
renatomameli pushed a commit to renatomameli/openapi-generator that referenced this pull request May 17, 2024
Co-authored-by: Rohit Sanjay <rohitsanjay@Rohits-MacBook-Pro.local>
@wing328 wing328 added this to the 7.6.0 milestone May 20, 2024
@rohitsanj rohitsanj deleted the use-pascalcase-instead-of-double-lambda branch July 14, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants