Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JavaScript] fix JS default ot ES6 #2084

Merged
merged 1 commit into from
Feb 8, 2019
Merged

[JavaScript] fix JS default ot ES6 #2084

merged 1 commit into from
Feb 8, 2019

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Feb 7, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh, ./bin/security/{LANG}-petstore.sh and ./bin/openapi3/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

JS client should default to ES6 instead of ES5. This PR fixes a bug to make sure the default is ES6

cc @CodeNinjai (2017/07) @frol (2017/07) @cliffano (2017/07)

@wing328 wing328 merged commit 7cee2b6 into master Feb 8, 2019
@wing328 wing328 added this to the 4.0.0 milestone Feb 8, 2019
@wing328 wing328 deleted the fix-js-default branch February 8, 2019 03:47
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant