Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add petstore integration tests to Ruby OAS3 client #2211

Merged
merged 4 commits into from
Feb 22, 2019
Merged

Add petstore integration tests to Ruby OAS3 client #2211

merged 4 commits into from
Feb 22, 2019

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Feb 22, 2019

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh, ./bin/security/{LANG}-petstore.sh and ./bin/openapi3/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

cc @cliffano (2017/07) @zlx (2017/09) @autopp (2019/02)

@wing328 wing328 added this to the 4.0.0 milestone Feb 22, 2019
@wing328 wing328 merged commit 163b004 into master Feb 22, 2019
@wing328 wing328 deleted the ruby_ci branch February 22, 2019 09:18
jimschubert added a commit that referenced this pull request Feb 23, 2019
* master: (40 commits)
  [Python] remove default value from being fallback to example (#2213)
  Add petstore integration tests to Ruby OAS3 client (#2211)
  Gradle - make GenerateTask properties optional (#2185)
  skip bats installation (#2198)
  Something in the dependencies changed. This switch is no longer needed. (#1850)
  Use oauth token for basic bearer auth in Rust. (#2161)
  Fix missing nullable (#2189)
  Enable error handling in Java WebClient library, fixes #1243 (#1244)
  [core] fix referenced enum case (#2175)
  rest-template: allow array parameters in path using collectionFormat (#2177)
  update go petstore samples
  Fix string types for cpprestsdk client generator (#1676)
  update kotline samples
  Remove API Key Authentication code for go when cookie is used. (#1601)
  changed the package install instructions to install the .tgz package … (#1989)
  okhttp-gson: allow array parameters in path using collectionFormat (#2137)
  [Ruby] Fix regualr expression in error message (#2069) (#2139)
  [kotlin][client] bytearray conversion (#2166)
  [rust-server] Added client documentation to rust-server (#2159)
  [Java] Getter/Setter naming convention not followed in generated models (#2095)
  ...
@autopp
Copy link
Contributor

autopp commented Feb 27, 2019

@wing328 How about deleting samples/openapi3/client/petstore/ruby/spec/ files other than samples/openapi3/client/petstore/ruby/spec/petstore_helper.rb and samples/openapi3/client/petstore/ruby/spec/custom/**/*.rb in bin/openapi3/ruby-client-petstore.sh?
In doing so, I think that generated test files will also be able to follow changes in the template.

@wing328
Copy link
Member Author

wing328 commented Feb 27, 2019

@autopp sounds good. Please feel free to file a PR for that.

@autopp
Copy link
Contributor

autopp commented Feb 28, 2019

@wing328 I submitted #2264

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants