-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update swagger-parser-version to 2.0.13-OpenAPITools.org-1 #2775
Update swagger-parser-version to 2.0.13-OpenAPITools.org-1 #2775
Conversation
pom.xml
Outdated
@@ -262,6 +262,7 @@ | |||
</requireMavenVersion> | |||
<requireReleaseDeps> | |||
<message>No Snapshots Allowed!</message> | |||
<onlyWhenRelease>true</onlyWhenRelease> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line must be removed when we switch to a release version!
WIP: |
I have fixed 2 tests in The Parser behave differently:
If our CI Tests do not detect more regression, I propose to continue with our release of Swagger-Parser. |
The samples were no longer up-to-date. I have pushed 3c18263 to fix this We see some changes with Example --- a/samples/server/petstore/jaxrs-jersey/src/gen/java/org/openapitools/model/EnumTest.java
+++ b/samples/server/petstore/jaxrs-jersey/src/gen/java/org/openapitools/model/EnumTest.java
@@ -107,13 +107,13 @@ public class EnumTest {
* Gets or Sets enumInteger
*/
public enum EnumIntegerEnum {
- NUMBER_1(1),
+ _1("1"),
- NUMBER_MINUS_1(-1);
+ _1("-1");
- private Integer value;
+ private Object value;
- EnumIntegerEnum(Integer value) {
+ EnumIntegerEnum(Object value) {
this.value = value;
}
@@ -124,7 +124,7 @@ public class EnumTest {
}
@JsonCreator
- public static EnumIntegerEnum fromValue(Integer value) {
+ public static EnumIntegerEnum fromValue(Object value) {
for (EnumIntegerEnum b : EnumIntegerEnum.values()) {
if (b.value.equals(value)) {
return b; We need to investigate, because I think that this is not OK. |
I found the reason for the regression we observe: This needs to be fixed before we can update Swagger-Parser cc: @cvgaviao |
Now that 2.0.13-OpenAPITools.org-1 is released to Maven Central, this PR can use this version and is no longer WIP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.master
,. Default:3.4.x
,4.0.x
master
.Description of the PR
Update the Swagger-Parser version to
2.0.13-OpenAPITools.org-1